Migrate to Android 12 and sdl_android 5.4.0#27
Merged
JulianKast merged 2 commits intoSmartDeviceLink-Examples:developfrom May 10, 2022
Merged
Conversation
Change compileSdkVersion and targetSdkVersion to 31 Update AndroidManifest to account for Bluetooth and USB changes in Android 12 Add a direct bluetooth permission request to MainActivity Update SdlReceiver to use a shared router service when possible Update PendingIntent flags to prevent crashes on Android 12 in WeatherAlarmManager
JulianKast
requested changes
Apr 25, 2022
| return; | ||
| } | ||
|
|
||
| SdlReceiver.queryForConnectedService(this); |
Contributor
There was a problem hiding this comment.
We do not want to call SdlReceiver.queryForConnectedService(this); here. If you look at the flow of the app, it gets called after the location permission is accepted. I would recommend that we tie in existing logic and request the nearby device permission after the location permission, possibly in SdlApplication.startService before it calls startSdlProxyService();. There are a couple of different ways to do it.
JulianKast
approved these changes
May 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change compileSdkVersion and targetSdkVersion to 31
Update AndroidManifest to account for Bluetooth and USB changes in Android 12
Add a direct bluetooth permission request to MainActivity
Update SdlReceiver to use a shared router service when possible
Update PendingIntent flags to prevent crashes on Android 12 in WeatherAlarmManager