Improve healthcheck command to inform about connectivity statuses for both proxy and server#599
Merged
sfc-gh-ksmogor merged 6 commits intomainfrom Oct 3, 2025
Conversation
…connectivity-statuses-for-both-proxy-and-server
sfc-gh-mjankowski
approved these changes
Oct 3, 2025
sfc-gh-ksmogor
deleted the
improve-healthcheck-command-to-inform-about-connectivity-statuses-for-both-proxy-and-server
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To improve troubleshooting I decorated connectivity errors between proxy and target. It is a little bit messy, but shows more explicitly that error is related to latter connection stage.
It cannot be done better (at least I think so) because of error handling design. We want service creators to handle errors and at the same time services cannot distinghuish between proxy and non-proxy connectivity (by design).
To improve this solution custom error structure should be sent between nodes on the protocol layer and service will still only receive well formatted string (golang err) to handle.