Skip to content

Comments

feat: allow adlib-actions to be marked as invalid#1609

Merged
Julusian merged 2 commits intoSofie-Automation:release53from
bbc:feat/allow-adlib-actions-invalid
Jan 26, 2026
Merged

feat: allow adlib-actions to be marked as invalid#1609
Julusian merged 2 commits intoSofie-Automation:release53from
bbc:feat/allow-adlib-actions-invalid

Conversation

@Julusian
Copy link
Member

About the Contributor

This pull request is posted on behalf of the BBC

Type of Contribution

This is a: Feature

Current Behavior

Adlib pieces can be set as invalid and show up greyed out in the shelf, but adlib actions cannot

New Behavior

Adlib actions can now be set as invalid

Using the demo-blueprints:
image

Testing

  • I have added one or more unit tests for this PR
  • I have updated the relevant unit tests
  • No unit test changes are needed for this PR

Affected areas

Time Frame

Other Information

Status

  • PR is ready to be reviewed.
  • The functionality has been tested by the author.
  • Relevant unit tests has been added / updated.
  • Relevant documentation (code comments, system documentation) has been added / updated.

@Julusian Julusian requested a review from a team as a code owner January 20, 2026 16:18
@coderabbitai
Copy link

coderabbitai bot commented Jan 20, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@jstarpl jstarpl added Contribution External contribution Contribution from BBC Contributions sponsored by BBC (bbc.co.uk) labels Jan 22, 2026
@Julusian Julusian merged commit 6271ffd into Sofie-Automation:release53 Jan 26, 2026
34 checks passed
@codecov
Copy link

codecov bot commented Jan 26, 2026

Codecov Report

❌ Patch coverage is 42.85714% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
packages/job-worker/src/playout/adlibAction.ts 50.00% 3 Missing ⚠️
packages/job-worker/src/blueprints/context/lib.ts 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@Julusian Julusian deleted the feat/allow-adlib-actions-invalid branch February 2, 2026 12:11
])
const adLibActionDoc = adLibAction ?? baselineAdLibAction ?? bucketAdLibAction

if (adLibActionDoc && adLibActionDoc.invalid)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you explain in what cases adLibActionDoc.invalid will be truthy? It is not included in any of the projections above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Contribution from BBC Contributions sponsored by BBC (bbc.co.uk) Contribution External contribution

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants