Skip to content

npm@latest and node 20 #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bourgeoa merged 1 commit into from
Apr 7, 2026
Merged

npm@latest and node 20 #234

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,10 +70,10 @@ jobs:
name: build
- uses: actions/setup-node@v6
with:
node-version: 22
node-version: 20
Copy link

Copilot AI Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This switches npm-publish-latest to Node 20, but the CI matrix builds/tests on Node 22/24 and .nvmrc pins v22.x. That means the publish path now runs on an untested Node version and is inconsistent with the repo’s declared Node version. Consider aligning the publish job with the tested/.nvmrc version, or add Node 20 to the build matrix (and ensure any tooling used during publish is compatible).

Suggested change
node-version: 20
node-version: 22

Copilot uses AI. Check for mistakes.
registry-url: 'https://registry.npmjs.org'
- name: Update npm to 10 (required for OIDC)
run: npm install -g npm@10
- name: Update npm to latest (required for OIDC)
run: npm install -g npm@latest
Comment on lines +75 to +76
Copy link

Copilot AI Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

npm install -g npm@latest makes the publish workflow non-deterministic and can start failing without code changes (e.g., when a new npm major drops that changes behavior or requires a newer Node engine than v20). Please pin npm to a specific major/version range known to support the chosen Node version (e.g., npm@10 or npm@^10) or keep Node aligned with the npm version you need for OIDC.

Suggested change
- name: Update npm to latest (required for OIDC)
run: npm install -g npm@latest
- name: Update npm to v10 (required for OIDC)
run: npm install -g npm@10

Copilot uses AI. Check for mistakes.
- name: Disable pre- and post-publish actions
run: 'sed -i -E "s/\"((pre|post)publish)/\"ignore:\1/" package.json'
- name: Publish to npm
Expand Down
Loading