Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #542 +/- ##
============================================
- Coverage 73.79% 73.79% -0.01%
+ Complexity 2953 2951 -2
============================================
Files 506 506
Lines 11954 11943 -11
Branches 669 669
============================================
- Hits 8822 8813 -9
+ Misses 2904 2903 -1
+ Partials 228 227 -1 |
Contributor
Author
|
@dmdashenkov, PTAL. |
dmdashenkov
suggested changes
Jun 9, 2020
| } | ||
| public boolean is(Class<? extends EnvironmentType> typeClass) { | ||
| EnvironmentType currentType = cachedOrCalculated(); | ||
| boolean result = currentType.getClass() |
Contributor
There was a problem hiding this comment.
I'd go with type.isInstance(..). That will give us an opportunity to create polymorphic types.
| } | ||
|
|
||
| // `Production` is the default fallback. | ||
| return new Production(); |
Contributor
There was a problem hiding this comment.
Seems like an illegal state to me.
Contributor
Author
|
@dmdashenkov, PTAL again. |
dmdashenkov
approved these changes
Jun 9, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR simplifies
EnvironmentTypeandEnvironment.EnvironmentNow, allows to check for the class with
boolean is(Class<? extends EnvironmentType>), instead ofboolean is(EnvironmentType)`.EnvironmentTypeNow, no longer overrides
equalsandhashCodein suspicious ways. Instead, it simply acts as a stricterinterfacefor a singleboolean enabled()method.Also, standard environment types are no longer singletons. We no longer encourage the extenders to be singletons as well.
Also resolves some Error Prone warnings.