Conversation
Also: * Improve display names of tests * Group tests
# Conflicts: # license-report.md # pom.xml # tools/errorprone-checks/src/main/java/io/spine/tools/check/vbuild/UseVBuild.java # version.gradle.kts
Codecov Report
@@ Coverage Diff @@
## master #585 +/- ##
============================================
+ Coverage 77.38% 77.41% +0.03%
- Complexity 2991 3000 +9
============================================
Files 501 503 +2
Lines 11541 11554 +13
Branches 667 667
============================================
+ Hits 8931 8945 +14
Misses 2382 2382
+ Partials 228 227 -1 |
... as newer API demands
... hoping to address test issues under Windows.
alexander-yevsyukov
requested review from
armiol
and removed request for
yuri-sergiichuk
dmdashenkov
approved these changes
Nov 6, 2020
armiol
requested changes
Nov 6, 2020
Collaborator
armiol
left a comment
armiol
left a comment
There was a problem hiding this comment.
@alexander-yevsyukov LGTM in general. Please see my comments.
base/src/test/java/io/spine/protobuf/MessageFieldExceptionTest.java
Outdated
Show resolved
Hide resolved
base/src/test/java/io/spine/validate/option/FieldValidatingOptionTest.java
Outdated
Show resolved
Hide resolved
tools/mute-logging/src/test/java/io/spine/testing/logging/MuteLoggingExtensionTest.java
Outdated
Show resolved
Hide resolved
tools/protoc-plugin/src/test/java/io/spine/tools/protoc/ExternalClassLoaderTest.java
Outdated
Show resolved
Hide resolved
tools/protoc-plugin/src/test/java/io/spine/tools/protoc/iface/GenerateInterfacesTest.java
Outdated
Show resolved
Hide resolved
tools/protoc-plugin/src/test/java/io/spine/tools/protoc/iface/InterfaceGeneratorTest.java
Outdated
Show resolved
Hide resolved
tools/protoc-plugin/src/test/java/io/spine/tools/protoc/iface/InterfaceGeneratorTest.java
Show resolved
Hide resolved
armiol
approved these changes
Nov 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
config.testlibwith utility classAssertions, adding methods for asserting throwing popular exceptions, and appliesthem to this project.
TempDirtesting utility, which aims to replaceFiles.createTempDir()from Guava.