Merged
Conversation
# Conflicts: # base/build.gradle.kts # base/src/main/java/io/spine/code/proto/ScalarType.java # base/src/test/java/io/spine/base/IdentifierTest.java # base/src/test/java/io/spine/reflect/given/ConstructorsTestEnv.java # license-report.md # pom.xml # tools/model-compiler/build.gradle.kts # tools/model-compiler/src/test/java/io/spine/tools/gradle/compiler/given/ModelCompilerTestEnv.java # tools/mute-logging/src/test/java/io/spine/testing/logging/MuteLoggingExtensionTest.java # tools/plugin-base/build.gradle.kts # tools/proto-js-plugin/src/main/java/io/spine/js/generate/field/parser/primitive/PrimitiveParsers.java # tools/proto-js-plugin/src/test/java/io/spine/js/generate/given/GivenProject.java # tools/proto-js-plugin/src/test/java/io/spine/js/gradle/ProtoJsPluginTest.java # tools/protoc-plugin/src/test/java/io/spine/tools/protoc/ClassMemberTest.java # tools/protoc-plugin/src/test/java/io/spine/tools/protoc/ExternalClassLoaderTest.java # tools/validation-generator/src/main/java/io/spine/tools/validate/AccumulateViolations.java # version.gradle.kts
Codecov Report
@@ Coverage Diff @@
## master #586 +/- ##
============================================
+ Coverage 77.50% 77.72% +0.21%
+ Complexity 3035 3034 -1
============================================
Files 508 508
Lines 11567 11533 -34
Branches 671 670 -1
============================================
- Hits 8965 8964 -1
+ Misses 2374 2341 -33
Partials 228 228 |
Contributor
Author
|
@alexander-yevsyukov, @armiol, PTAL. |
alexander-yevsyukov
approved these changes
Nov 9, 2020
Contributor
alexander-yevsyukov
left a comment
alexander-yevsyukov
left a comment
There was a problem hiding this comment.
LGTM, with one minor question.
| @@ -37,9 +37,11 @@ | |||
| @SuppressWarnings("BadImport") // refer to `FieldDescriptor.Type` as `Type` in this class. | |||
Contributor
There was a problem hiding this comment.
Do we need this suppression, assuming we have them in-place below?
armiol
approved these changes
Nov 9, 2020
Collaborator
armiol
left a comment
armiol
left a comment
There was a problem hiding this comment.
@dmdashenkov LGTM in general. Please see my comments though.
| /** | ||
| * A factory of Groovy strings. | ||
| * | ||
| * @deprecated Since the latest changes in the Protobuf Gradle plugin, usage Groovy strings in Java |
tools/protoc-plugin/build.gradle.kts
Outdated
| else -> zipTree(it) | ||
| } | ||
| }) | ||
| // We should provide a classifier or else Protobuf Gradle plugin will substitute an OS-specific |
Collaborator
There was a problem hiding this comment.
Sorry to bother you again on the same matter, but I think it's will substitute it with an OS-specific one.
# Conflicts: # license-report.md # pom.xml
# Conflicts: # license-report.md # pom.xml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The latest version of Protobuf Gradle plugin allows using a runnable JAR as a
protocplugin instead of an executable file. This means less work for us.This PR also updates third-party dependencies, including ErrorProne. New ErrorProne warnings are addressed.