Merged
Conversation
It needs to be H3, while IDEA mistakenly requires it to be H1.
It needs to be H3, while IDEA mistakenly requires it to be H1.
... instead of public constant, which cased security warning.
Codecov Report
@@ Coverage Diff @@
## master #594 +/- ##
============================================
+ Coverage 77.73% 77.77% +0.04%
Complexity 3036 3036
============================================
Files 509 510 +1
Lines 11538 11529 -9
Branches 669 670 +1
============================================
- Hits 8969 8967 -2
+ Misses 2341 2335 -6
+ Partials 228 227 -1 |
armiol
approved these changes
Nov 26, 2020
Collaborator
|
@alexander-yevsyukov LGMT as soon as the builds pass. Also, I remembered why we had However, now I think that was an over-complication as there was no such cases at the moment. Still, we will probably face such a need some time in future. Once we do, we'll design a solution for it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the API of working with the
Environment, making it consistent with howServerEnvironmentworks incore-java.Notable changes:
CustomEnvironmentTypewas introduced primarily for helping understand the concept of a custom type, and avoid ambiguity when speaking about “mutual exclusivity”. Previously, all the types were descending fromEnvironmentTypeand two of them beingTestsandProductionwere always present, and, thus, one of them could not be mutually exclusive with a custom one. Yes, they were standard ones, but it still raised the question, and because of that...StandardEnvironmentTypewas introduced. It's package-private with the primary purpose of gropingTestsandProductiontypes together.Class<? extends CustomEnvironmentType>, not an instance of a type. This plays nicer withServerEnvironment.when(Class). As we mimicenums let's be operating with classes, not instances.Environmentwere removed.