Some viewer-related fixes#4030
Merged
Faithcaio merged 2 commits intoSpongePowered:api-11from Jun 23, 2024
Merged
Conversation
8 tasks
Faithcaio
reviewed
Jun 23, 2024
src/main/java/org/spongepowered/common/data/provider/item/stack/BookItemStackData.java
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Viewer#sendWorldType():
ClientLevel#effectsso we need to modify it instead of modifying actual DimensionTypeimplements LevelBridgefromClientLevelMixinbecauseLevelMixinalready implements itBookItemStackData:
WrittenBookContentor keep current keys but for now I just made it working with current stuffBookUtil:
bookSlotwas changed frominventory.items.size() + inventory.selectedtoinventory.selectedand container id was changed from0to-2because the only reason it works now is that (picture) size of red area (inventoryMenuindexing) luckily equals to size of blue area (inventory.items.size()).-2stands forPlayer#inventoryand first 9 items in it is hotbar