Skip to content

Implement scaling for display entities#4111

Merged
Yeregorix merged 3 commits intoSpongePowered:api-12from
DrZoddiak:display-scale
Sep 13, 2025
Merged

Implement scaling for display entities#4111
Yeregorix merged 3 commits intoSpongePowered:api-12from
DrZoddiak:display-scale

Conversation

@DrZoddiak
Copy link
Contributor

Implements #setScale for Display Entities since they allow for scaling in 3 directions.

Copy link

@boxbeam boxbeam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes good

@avaruus1
Copy link
Contributor

avaruus1 commented Jul 15, 2024

How does this differ from setting the scale through the Transform or is it just a different way of doing the same thing?

@DrZoddiak
Copy link
Contributor Author

How does this differ from setting the scale through the Transform or is it just a different way of doing the same thing?

Effectively it's the same thing. Interpolation keys still effect the entity. This PR simply implements a method that already exists but has no implementation.

@Override
public Vector3d scale() {
return Vector3d.ONE;
}
@Override
public void setScale(final Vector3d scale) {
// do nothing, Minecraft doesn't properly support this yet
}

Copy link
Member

@gabizou gabizou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small nit, and I'm good with merging.

@Yeregorix Yeregorix changed the base branch from api-11 to api-12 September 13, 2025 10:10
@Yeregorix Yeregorix merged commit 0f4eb5e into SpongePowered:api-12 Sep 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants