Implement scaling for display entities#4111
Merged
Yeregorix merged 3 commits intoSpongePowered:api-12from Sep 13, 2025
Merged
Conversation
Contributor
|
How does this differ from setting the scale through the Transform or is it just a different way of doing the same thing? |
Contributor
Author
Effectively it's the same thing. Interpolation keys still effect the entity. This PR simply implements a method that already exists but has no implementation. |
gabizou
approved these changes
Sep 13, 2024
Member
gabizou
left a comment
There was a problem hiding this comment.
One small nit, and I'm good with merging.
src/mixins/java/org/spongepowered/common/mixin/api/minecraft/world/entity/DisplayMixin_API.java
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements
#setScalefor Display Entities since they allow for scaling in 3 directions.