fix: Issues related to fireworks and fused explosives#4117
Merged
aromaa merged 12 commits intoSpongePowered:api-11from Aug 25, 2024
Merged
fix: Issues related to fireworks and fused explosives#4117aromaa merged 12 commits intoSpongePowered:api-11from
aromaa merged 12 commits intoSpongePowered:api-11from
Conversation
aromaa
requested changes
Aug 23, 2024
Member
aromaa
left a comment
aromaa
left a comment
There was a problem hiding this comment.
Overall looks good, few comments.
...java/org/spongepowered/common/mixin/api/minecraft/world/entity/monster/CreeperMixin_API.java
Outdated
Show resolved
Hide resolved
src/mixins/java/org/spongepowered/common/mixin/core/world/entity/item/PrimedTntMixin.java
Outdated
Show resolved
Hide resolved
This reverts commit 9c791a4.
aromaa
reviewed
Aug 25, 2024
src/mixins/java/org/spongepowered/common/mixin/core/world/entity/monster/CreeperMixin.java
Outdated
Show resolved
Hide resolved
aromaa
approved these changes
Aug 25, 2024
Member
aromaa
left a comment
aromaa
left a comment
There was a problem hiding this comment.
LGTM! Thank you!!
Another thing I noticed was that the FIREWORK_FLIGHT_MODIFIER is Ticks but we more of treat it as int which seems problematic.. There is also no direct way to change the lifetime as actual Ticks which would be helpful, but all of those are unrelated here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4116
IS_PRIMEDfor all fused explosivesTICKS_REMAININGthrowing an error for anything other thanPrimedTNTFUSE_DURATIONalways rejectingdetonatemethod of Creeper only igniting, not exploding it (other methods explode)FIREWORK_FLIGHT_MODIFIER(not sure if this is wanted)