Support reloadable registries#4132
Closed
MrHell228 wants to merge 2 commits intoSpongePowered:api-12from
Closed
Conversation
Member
|
Superseded by #4179. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
RegistryAccessfor server from default access to full access (from ReloadableResources, full access contains registries from default access plus few additional ones). The only additional registries are 3 related to loot tables registries.Also added handler for registries on data pack reload. Currently we dont update registries even though they are actually changed (replaced with completely new registry) because of data packs add/removal. Reloadable registries include 3 loot registries and some registries from default access.
About
GeneratorMain: I don't really know what deleted line is supposed to do, but I widened access here too, nothing broke and now it can generate loot tables which wasn't possible before.