Missing event when middle mouse click on a block/entity#4219
Merged
Yeregorix merged 1 commit intoSpongePowered:api-14from Sep 15, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #4171
Bug
When performing a middle mouse click in creative mode on a block or an entity, the warning
Logged slot transactions without event! 1 net.minecraft.world.inventory.InventoryMenufollowed by an exception was printed in the console.Fix
Log a click container transaction when the player picks a block or an entity.
Notes
buttonNum is set to 0 because the packet doesn't contain this information, but the value is not used in MiddleInventoryClickState.
I wanted to add the mixin before the
broadcastChangesbut the slot number was not available at that point (I don't know why), so I added it afterfindSlotMatchingItem.I acknowledge that the instanceof in ClickMenuTransaction is not very clean but I wanted to minimize code changes.