Skip to content

Fix dimension query#4259

Merged
Yeregorix merged 1 commit intoSpongePowered:api-12from
MrSlimeDiamond:api12/fix-dimension-query
Dec 10, 2025
Merged

Fix dimension query#4259
Yeregorix merged 1 commit intoSpongePowered:api-12from
MrSlimeDiamond:api12/fix-dimension-query

Conversation

@MrSlimeDiamond
Copy link
Contributor

This fixes getting an offline player's location via User#worldKey()

At some point, it was renamed to Dimension instead of WorldKey I suppose

SpongeEntityArchetype was changed but seemingly nothing is different in my testing?

This fixes getting an offline player's location via User#worldKey()

At some point, it was renamed to Dimension instead of WorldKey I suppose
@Yeregorix
Copy link
Member

Thank you for spotting this. IRC back in the days, the dimension field was just a int and Sponge had to store a custom field WorldKey for the full string id. Then Mojang refactored their dimensions system and added a Dimension field with the string id.

@Yeregorix Yeregorix merged commit cd5c211 into SpongePowered:api-12 Dec 10, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants