Mark logging macros with #[clippy::format_args] attribute#115
Draft
Mark logging macros with #[clippy::format_args] attribute#115
#[clippy::format_args] attribute#115Conversation
Co-authored-by: Asuna <SpriteOvO@gmail.com>
SpriteOvO
force-pushed
the
main-dev
branch
10 times, most recently
from
58d8367 to
ed5440c
Compare
SpriteOvO
force-pushed
the
main-dev
branch
3 times, most recently
from
0350263 to
3aaef62
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables clippy lints for
format_args!(such asuninlined_format_args,format_in_format_args, etc.) for our logging macros.Checklists
macro_exported macro and reexporting it incorrectly triggers the macro_expanded_macro_exports_accessed_by_absolute_paths error rust-lang/rust#98291.clippy::format_argsis introduced since clippy v1.85, since our MSRV is lower than that version, we need to put some attr likeignore_unknown_lintfor lower version users, or wait for our MSRV reached that version.