fix(markdown-mode): prevent block change from stripping numbers#140
Merged
dancormier merged 4 commits intomainfrom Jun 16, 2022
Merged
fix(markdown-mode): prevent block change from stripping numbers#140dancormier merged 4 commits intomainfrom
dancormier merged 4 commits intomainfrom
Conversation
dancormier
added
bug
✅ Deploy Preview for nifty-lalande-39c157 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
b-kelly
approved these changes
Jun 16, 2022
Contributor
b-kelly
left a comment
b-kelly
left a comment
There was a problem hiding this comment.
lgtm. Added support for 12) as well, since ) is also a valid ordered list marker (see the spec). I also added the @internal TSDoc tag as well, which I only recently realized was a thing.
Contributor
Author
In the course of building this, I realized that we should support It's 🦐-in' time! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #69
Describe your changes
This PR prevents markdown mode commands from stripping numbers from the beginning of strings when changing the block type. It achieves this by checking first for ordered list block types then for any non-alphanumeric leading characters.
PR Checklist
/** ... */docsbug/enhancementand other labels as appropriateEnvironment(s) tested
Additional context
The regexes in
matchLeadingBlockCharacterscould for sure use some work. This PR targets the specific issue mentioned in #69 but could be refactored to check leading characters per the markdown spec.