Skip to content

Link editor enhancements#142

Merged
b-kelly merged 43 commits intomainfrom
bkelly/link-editor
Jun 28, 2022
Merged

Link editor enhancements#142
b-kelly merged 43 commits intomainfrom
bkelly/link-editor

Conversation

@b-kelly
Copy link
Contributor

@b-kelly b-kelly commented Jun 17, 2022

Closes #19.

Describe your changes

Draft PR for moving link editing out of the tooltip and into the plugin container.

PR Checklist

  • All new/changed functionality includes unit and (optionally) e2e tests as appropriate
  • All new/changed functions have /** ... */ docs
  • I've added the bug/enhancement and other labels as appropriate

b-kelly and others added 29 commits May 16, 2022 15:27
* chore: add PR template

* chore(pull_request_template): formatting and add checklist item

Co-authored-by: Ben Kelly <b-kelly@users.noreply.github.com>
# Conflicts:
#	package-lock.json
#	package.json
#	src/commonmark/editor.ts
#	src/external-plugins/stack-snippets.ts
#	src/rich-text/commands/index.ts
#	src/rich-text/editor.ts
#	src/rich-text/plugins/link-editor.ts
#	src/rich-text/schema.ts
#	src/shared/external-editor-plugin.ts
#	src/shared/prosemirror-plugins/image-upload.ts
#	src/shared/prosemirror-plugins/interface-manager.ts
#	test/rich-text/plugins/link-editor.test.ts
#	test/shared/plugins/image-upload.test.ts
@b-kelly b-kelly added the enhancement New feature or request label Jun 17, 2022
@netlify
Copy link

netlify bot commented Jun 17, 2022

Deploy Preview for nifty-lalande-39c157 ready!

Name Link
🔨 Latest commit ab4fe38
🔍 Latest deploy log https://app.netlify.com/sites/nifty-lalande-39c157/deploys/62bb5525c38e470009de82ef
😎 Deploy Preview https://deploy-preview-142--nifty-lalande-39c157.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@b-kelly b-kelly force-pushed the main branch 4 times, most recently from b84f781 to db0a798 Compare June 24, 2022 15:03
@b-kelly b-kelly marked this pull request as ready for review June 28, 2022 19:35
@b-kelly b-kelly merged commit 368fa3d into main Jun 28, 2022
@b-kelly b-kelly deleted the bkelly/link-editor branch June 28, 2022 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Link insertion / editing enhancements

3 participants