if sqs sensor config None set to None#121
if sqs sensor config None set to None#121amanda11 merged 4 commits intoStackStorm-Exchange:masterfrom satellite-no:feature/allow-ec2-role
Conversation
|
@amanda11 |
|
sean.elliott seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
Any one want to give me the old review? @armab |
amanda11
left a comment
There was a problem hiding this comment.
LGTM - perhaps longer term the access_key_id shouldn't really be mandatory, so that you can actually omit those parameters rather than setting to "None".
Can you sign the CLA first though, before we approve?
|
I've signed it several times trying to get the PR to update. Nothing ever updates or shows I signed the CLA. |
Is it associated with the wrong email perhaps? It doesn't even think you are a github user? |
|
Ha, got it! I thought... |
|
good? |
Still failing on CLA Looking at the history of the commits, we need to get the author changed on the previous 2 commits to the same email you used on the update readme, and then it should pass. |
|
Got it! that was a learning experience LOL. |
amanda11
left a comment
There was a problem hiding this comment.
LGTM - thanks for the contribution, and the fun with git!
Following the action method of setting the keys to
Nonewhich allows AWS to assume the EC2 role vs failing with a key/secret of"None".fixes #120