Skip to content

[Enhancement] Optimize mv best selector strategy on distributed keys#69679

Merged
LiShuMing merged 1 commit into
StarRocks:mainfrom
LiShuMing:opt_mv_selector_dist_keys
Mar 4, 2026
Merged

[Enhancement] Optimize mv best selector strategy on distributed keys#69679
LiShuMing merged 1 commit into
StarRocks:mainfrom
LiShuMing:opt_mv_selector_dist_keys

Conversation

@LiShuMing

@LiShuMing LiShuMing commented Mar 2, 2026

Copy link
Copy Markdown
Contributor

Why I'm doing:

  • Prefer the chosen MV whose dist keys are satisfied with the user queries' EQ filter.

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
    • This pr needs auto generate documentation
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 4.1
    • 4.0
    • 3.5
    • 3.4

@LiShuMing LiShuMing requested a review from a team as a code owner March 2, 2026 07:37
@CelerData-Reviewer

Copy link
Copy Markdown

@codex review

@github-actions

github-actions Bot commented Mar 2, 2026

Copy link
Copy Markdown
Contributor

🌎 Translation Required?

All translation files are up to date.
No translation actions are required for this PR.

🕒 Last updated: Mon, 02 Mar 2026 07:40:20 GMT

@github-actions github-actions Bot added the docs-maintainer Picked up by the weekly docs triage workflow label Mar 2, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1ad3a61a37

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Signed-off-by: shuming.li <ming.moriarty@gmail.com>
@LiShuMing LiShuMing force-pushed the opt_mv_selector_dist_keys branch from 969add5 to 37a9e8d Compare March 3, 2026 08:35
@github-actions

github-actions Bot commented Mar 3, 2026

Copy link
Copy Markdown
Contributor

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

@github-actions

github-actions Bot commented Mar 3, 2026

Copy link
Copy Markdown
Contributor

[FE Incremental Coverage Report]

pass : 6 / 6 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/sql/optimizer/rule/transformation/materialization/BestMvSelector.java 6 6 100.00% []

@github-actions

github-actions Bot commented Mar 3, 2026

Copy link
Copy Markdown
Contributor

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

@sonarqubecloud

sonarqubecloud Bot commented Mar 3, 2026

Copy link
Copy Markdown

@LiShuMing LiShuMing merged commit 7ad2212 into StarRocks:main Mar 4, 2026
53 checks passed
@LiShuMing LiShuMing deleted the opt_mv_selector_dist_keys branch March 4, 2026 07:14
@github-actions

github-actions Bot commented Mar 4, 2026

Copy link
Copy Markdown
Contributor

@Mergifyio backport branch-4.0

@github-actions

github-actions Bot commented Mar 4, 2026

Copy link
Copy Markdown
Contributor

@Mergifyio backport branch-4.1

@mergify

mergify Bot commented Mar 4, 2026

Copy link
Copy Markdown
Contributor

backport branch-4.0

✅ Backports have been created

Details

@mergify

mergify Bot commented Mar 4, 2026

Copy link
Copy Markdown
Contributor

backport branch-4.1

✅ Backports have been created

Details

mergify Bot pushed a commit that referenced this pull request Mar 4, 2026
…69679)

Signed-off-by: shuming.li <ming.moriarty@gmail.com>
(cherry picked from commit 7ad2212)
mergify Bot pushed a commit that referenced this pull request Mar 4, 2026
…69679)

Signed-off-by: shuming.li <ming.moriarty@gmail.com>
(cherry picked from commit 7ad2212)
wanpengfei-git pushed a commit that referenced this pull request Mar 4, 2026
…(backport #69679) (#69782)

Signed-off-by: shuming.li <ming.moriarty@gmail.com>
Co-authored-by: shuming.li <ming.moriarty@gmail.com>
wanpengfei-git pushed a commit that referenced this pull request Mar 4, 2026
…(backport #69679) (#69783)

Signed-off-by: shuming.li <ming.moriarty@gmail.com>
Co-authored-by: shuming.li <ming.moriarty@gmail.com>
srihithg pushed a commit to srihithg/starrocks that referenced this pull request Mar 9, 2026
…tarRocks#69679)

Signed-off-by: shuming.li <ming.moriarty@gmail.com>
Signed-off-by: Srihith Garlapati <srihith.garlapati@gmail.com>
wxl24life pushed a commit to wxl24life/starrocks that referenced this pull request Mar 10, 2026
DanRoscigno pushed a commit to chris-celerdata/starrocks that referenced this pull request Apr 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4.0-merged 4.1-merged docs-maintainer Picked up by the weekly docs triage workflow

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants