Bugfix 918#930
Merged
Merged
Conversation
When an assembly name starts with a digit (e.g. '1ConsoleApp'), the generated VogenTypesFactory, BSON registration class, and OpenAPI mapping class were placed in an invalid namespace/identifier. Two-part fix: 1. ProjectName.FromAssemblyName now prepends '_' if the sanitised name starts with a digit, preventing invalid C# identifiers. 2. ValueObjectGenerator pipes the MSBuild 'RootNamespace' property (via AnalyzerConfigOptionsProvider) through the incremental pipeline. All three affected generators — GenerateCodeForSystemTextJsonConverterFactories, GenerateCodeForOpenApiSchemaCustomization, and GenerateCodeForBsonSerializers — now call ProjectName.FromRootNamespaceOrAssemblyName, which prefers the explicit RootNamespace over the (sanitised) assembly name. This means a project with AssemblyName='1ConsoleApp' and RootNamespace='OneConsoleApp' produces 'namespace OneConsoleApp' as expected. Adds samples/1MyProg as a repro project. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…RootNamespace) - ProjectBuilder: add _buildProperties dict, WithBuildProperty method, wire TestAnalyzerConfigOptionsProvider into the CSharpGeneratorDriver via WithUpdatedAnalyzerConfigOptions so build properties reach the generator - SnapshotRunner: add WithBuildProperty fluent method, forward to ProjectBuilder - New test Bug918_AssemblyNameStartingWithDigit: two tests covering the digit- prefix guard (_1MyProject) and RootNamespace override (OneProject) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
A RootNamespace value like 'My-Project' or '1Foo' would otherwise produce an invalid C# identifier. Extract a private Normalise() helper and route both paths through it. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #918