Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion src/Writers/FunctionWriter.php
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@
use PhpParser\Node\Arg;
use PhpParser\Node\Expr\FuncCall;
use PhpParser\Node\Name;
use PhpParser\Node\Scalar\Float_;
use PhpParser\Node\Scalar\Int_;
use PhpParser\Node\Scalar\String_;

class FunctionWriter
Expand Down Expand Up @@ -85,12 +87,28 @@ private function convertToArgs($args)
{
return collect($args)
->reject(fn ($arg) => $arg === null || mb_strlen($arg) === 0)
->map(fn (string $arg) => new Arg(new String_($arg)))
->map(fn (mixed $arg) => $this->arg($arg))
->all();
}

private function convertToName(string $name)
{
return new Name($name);
}

private function scalarClass(string $type): string
{
return match ($type) {
'integer' => Int_::class,
'double' => Float_::class,
default => String_::class,
};
}

private function arg(mixed $arg): Arg
{
$scalarClass = $this->scalarClass(gettype($arg));

return new Arg(new $scalarClass($arg));
}
}
13 changes: 13 additions & 0 deletions tests/LaravelFunctionCallTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,20 @@ public function testCustomCallsCanBeWritten()
);
}

public function testTypesAreMaintained()
{
$f = new FunctionWriter;

$this->assertChangeEquals(
__DIR__.'/configs/empty.php',
__DIR__.'/expected/typesenv.php',
[
'int_type' => $f->env('INTEGER_TYPE', 5),
'double_type' => $f->env('DOUBLE_TYPE', 5.0),
'string_type' => $f->env('STRING_TYPE', '5'),
]
);
}

public function testWritingNewClosuresOrArrowFunctions()
{
Expand Down
7 changes: 7 additions & 0 deletions tests/expected/typesenv.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
<?php

return [
'int_type' => env('INTEGER_TYPE', 5),
'double_type' => env('DOUBLE_TYPE', 5.0),
'string_type' => env('STRING_TYPE', '5'),
];