Conversation
|
Looks good to me; thanks for being more diligent than myself. Would you prefer that I merge it in now, or would you rather I wait for the map parsing fix? |
|
I say merge it now; then anyone who wants to work on the map parsing fix can do it right on the branch. |
|
Now this PR is even better (hopefully you agree) with the addition of a full set of LotV abilities and units thanks to @mischanix. |
|
Some notes on the dump script change (feel free to amend the commit with these):
Ping me when there's another build of LotV and I'll update it and try to rewrite the instructions for future updates; until then, I'm not going to make a guess at what offsets change from build-to-build. |
|
Sweet. Thanks for the new data dump. |
Hi @StoicLoofah I added two tests, one for simple replay parsing which passes, and another for map parsing which currently fails.
I'll look at the map parsing and see if I can figure out what's going on... if not then hopefully the big guns like @GraylinKim can figure it out