handle 3.0 replays, work in progress.#2
Conversation
test now passes, meaning that we can parse the replay without barfing. test doesn't check the parsed data at all; just confirms that no exception is thrown.
There was a problem hiding this comment.
Yeah, it is kind of shitty how this bit of code turned out. I can never get up the motivation to rewrite for less repetition though.
|
Did you do a diff of the protocols to get these changes or sorta try, fail, lookup new value, change? I wrote a script at some point to flatten the nested protocols into something that you can diff. I'll add that to the repo tonight if I can find it. |
|
Good question @GraylinKim I went back to the protocol and diffed more carefully and added more stuff. |
There was a problem hiding this comment.
just for my own knowledge, why do we need the subtraction here?
There was a problem hiding this comment.
the subtraction is because of https://github.com/Blizzard/s2protocol/blob/master/protocol38215.py#L110
it's a type ggtracker#84, and in this case the x, y and z are part of a type ggtracker#93. https://github.com/Blizzard/s2protocol/blob/master/protocol38215.py#L119
There was a problem hiding this comment.
makes sense. thanks for the explanation!
|
looks good to me. I'll merge this in so at least I can get this in production to see what other bugs come up. Thanks for getting this done so quickly! |
handle 3.0 replays, work in progress.
3 participants
test now passes, meaning that we can parse the replay without barfing.
test doesn't check the parsed data at all; just confirms that no exception is thrown.