Display world screenshot previews and progress by provigz · Pull Request #2349 · SuperTux/supertux

provigz · 2022-12-04T19:25:00Z

WorldSetMenu and SortedContribMenu now inherit the new WorldPreviewMenu class, which allows displaying profile-specific world previews and progress. A preview for a world is generated each time the user leaves its worldmap. Only worldmap levelsets support this feature.
Supported also are optional placeholder world previews, which have to be named preview.png, and stored in the relative to levels directory for the world.

FileSystemMenu also now shows previews of images, when hovering over an image file.

fixes #2286

Frostwithasideofsalt · 2025-04-14T23:34:19Z

builds failing, cant test

tobbi · 2025-04-15T06:29:45Z

Needs another rebase against master

Frostwithasideofsalt

All of my issues have been resolved.

provigz · 2025-06-29T14:22:46Z

Only issue I see left with this PR is that the worldmap menu is shown in the world screenshot when using the OpenGL renderer on Windows. Considering the default renderer now is SDL, maybe we should merge this and maybe consider this issue for another time, as it's minor and likely directly related to the OpenGL video code.

bruhmoent · 2025-06-29T14:24:08Z

I'd say that if it ONLY happens with the OpenGL renderer, I'd let it slip by for now.

provigz · 2025-06-29T14:27:47Z

From my testing, SDL was fine. I encourage you to test it.

tobbi · 2025-07-02T17:58:26Z

Instead of "perfected", how about "perfect"?

bruhmoent

First image steps: Start game -> Contrib Levels -> Community Levels -> Back -> Back -> Start menu shifted
And when there are no add-ons installed, the contrib levels menu shouldn't shift

provigz · 2025-07-02T20:31:43Z

Isn't it shifted in the first screenshot because of Story Mode?

bruhmoent · 2025-07-02T20:36:03Z

There isn't a preview visible, as shown in the screenshot

provigz · 2025-07-02T20:37:42Z

And there is no progression or anything from Story Mode that shows up on the right? Then sure.

Alasdairbugs · 2025-08-24T21:10:04Z

"Perfected" is the proper english term for perfecting a level, so that should stay @tobbi

tobbi · 2025-08-24T22:29:28Z

"Perfected" is the proper english term for perfecting a level, so that should stay @tobbi

Ah, alright!

…/empty previews with no data

…d with progress; show "Story mode" progress

How did I let this pass??

… towards level progress

…e total level count in stats

provigz · 2025-08-27T23:52:01Z

This PR should be ready (review if you could), however I am getting a segfault/signal 6 when making a screenshot on the SDL renderer.

It might be a bug within SDL_RenderReadPixels on SDL2-compat. I'm also getting the following error when SDLPainter::get_pixel() runs, which also uses the function:

src/video/sdl/sdl_painter.cpp:635 failed to read pixels: Can't read outside the current viewport

swagtoy

Rebase too

swagtoy · 2025-12-14T21:39:45Z

 #include "util/string_util.hpp"

+static const size_t MAX_TITLE_CHARS = 30;
+static const std::vector<std::string> IMAGE_EXTENSIONS = { ".jpg", ".png", ".surface" };


std array or just a C style array. Try std stringview

swagtoy · 2025-12-14T21:41:48Z

+}
+
+bool
+FileSystemMenu::is_image(const std::string& file) const


smells like unsound logic anyway. sdl image might have something to check this? try running it through and seeing if a valid surface is returned if it doesnt.

granted, thats kinda rare. plus, what about .jpeg and whatever? maybe im looking at this wrong

swagtoy · 2025-12-14T21:42:33Z

+void
+MenuItem::set_preview(const std::string& preview_file)
+{
+  m_preview = Surface::from_file(preview_file);


error check

swagtoy · 2025-12-14T21:44:24Z

        .set_help(_("Enable screen transitions and smooth menu animation"));

+      add_toggle(MNID_WORLD_PREVIEWS, _("Show world previews"), &g_config->show_world_previews)
+        .set_help(_("Show screenshot previews of the last worldmap state, when hovering over a world."));


remove comma

swagtoy · 2025-12-14T21:45:55Z

@@ -1,5 +1,6 @@
 //  SuperTux
 //  Copyright (C) 2021 mrkubax10 <mrkubax10@onet.pl>
+//                2022-2023 Vankata453


bump, change name to yours

swagtoy · 2025-12-14T21:47:57Z

+WorldPreviewMenu::menu_action(MenuItem& item)
+{
+  const int index = item.get_id();
+  if (index >= 0 && index < static_cast<int>(m_world_entries.size())) // Valid world index.


flip logic and early return

swagtoy · 2025-12-14T21:49:56Z

 }

+uint32_t
+Savegame::Progress::get_percentage() const


why not int? also its a percentage, why not double?

swagtoy · 2025-12-14T21:50:30Z

+    {}
+    uint32_t solved;
+    uint32_t perfect;
+    uint32_t total;


just use unsigned

swagtoy · 2025-12-14T21:52:01Z



+void
+WorldMap::take_preview_screenshot()


show a dialog and also log SDL_GetError (if applicable(

swagtoy · 2025-12-14T21:55:14Z

We could probably use getpixel api instead of sdl screenshot. dunno how thatd work on the gl backend

Display world screenshot previews and progress

19b45a5

mrkubax10 added type:feature category:code status:needs-review Work needs to be reviewed by other people labels Dec 6, 2022

provigz added 8 commits December 12, 2022 18:34

Move preview functionality to menus and menu items

058899e

Merge branch 'master' into world-previews

692d5a0

FileSystemMenu now shows previews of images

c38af90

Cast integers to floats when generating preview rect

78094b3

Cast world entries vector size to int

24dc82f

Merge remote-tracking branch 'supertux/master' into world-previews

5cd4f74

Don't fade in/out previews when transitions are disabled

9be8c3d

Merge branch 'master' into world-previews

bbd65fe

mrkubax10 approved these changes Jun 23, 2023

View reviewed changes

provigz marked this pull request as draft June 24, 2023 14:47

Narre mentioned this pull request Jul 18, 2023

Show progress in contrib level menus #2040

Closed

provigz added 6 commits July 27, 2023 16:33

Merge remote-tracking branch 'supertux/master' into world-previews

9a9d115

Remove some header includes

c0ba8e5

Show progress percentage for worlds

3c5ecec

General code improvements

7cdf956

Get level progress from savefile level tables

062c452

Allow toggling world previews functionality

827d922

provigz marked this pull request as ready for review August 5, 2023 23:46

provigz requested review from Rusty-Box and mrkubax10 August 5, 2023 23:46

provigz added 2 commits August 6, 2023 03:00

Use unsigned integers for storing progress

1149313

Add <sstream> include

8a23ab0

provigz mentioned this pull request Aug 6, 2023

Old levelpacks are marked as new #1251

Closed

provigz added 2 commits August 6, 2023 20:22

Do not draw menu item previews, if preview overlaps the menu

91ea207

WorldMapState now loads/saves state for all sectors

17e2259

tobbi reviewed Oct 27, 2023

View reviewed changes

Comment thread src/supertux/savegame.hpp

Merge branch 'SuperTux:master' into world-previews

cf698d8

Frostwithasideofsalt approved these changes Apr 22, 2025

View reviewed changes

bruhmoent requested changes Jul 2, 2025

View reviewed changes

provigz added 7 commits August 27, 2025 17:48

Merge remote-tracking branch 'supertux/master' into world-previews

955e88e

Do not show "No preview data available" text, do not fade out invalid…

30792f1

…/empty previews with no data

WorldPreviewMenu: Only force previews if there is at least one worl…

211155e

…d with progress; show "Story mode" progress

Fix WorldMapSector referencing current sector when it shouldn't have

a4f4be5

How did I let this pass??

Allow marking level tiles on worldmap as cutscenes, do not count them…

247d32f

… towards level progress

Count levels from unloaded referenced worldmaps via teleporters to th…

9860163

…e total level count in stats

Do not take worldmap preview screenshots in Editor

60efe14

Merge remote-tracking branch 'supertux/master' into world-previews

475aa60

provigz requested a review from swagtoy December 14, 2025 20:55

swagtoy requested changes Dec 14, 2025

View reviewed changes

provigz modified the milestones: 0.7.0, 0.7.1 Dec 15, 2025

swagtoy force-pushed the master branch 2 times, most recently from 806ca6a to c12b71b Compare March 15, 2026 04:42



		void
		WorldMap::take_preview_screenshot()

Uh oh!

Conversation

provigz commented Dec 4, 2022 • edited by MatusGuy Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Frostwithasideofsalt commented Apr 14, 2025

Uh oh!

tobbi commented Apr 15, 2025

Uh oh!

Frostwithasideofsalt left a comment

Choose a reason for hiding this comment

Uh oh!

provigz commented Jun 29, 2025

Uh oh!

bruhmoent commented Jun 29, 2025

Uh oh!

provigz commented Jun 29, 2025

Uh oh!

tobbi commented Jul 2, 2025

Uh oh!

bruhmoent left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

provigz commented Jul 2, 2025

Uh oh!

bruhmoent commented Jul 2, 2025

Uh oh!

provigz commented Jul 2, 2025

Uh oh!

Alasdairbugs commented Aug 24, 2025

Uh oh!

tobbi commented Aug 24, 2025

Uh oh!

provigz commented Aug 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

swagtoy left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

swagtoy commented Dec 14, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

provigz commented Dec 4, 2022 •

edited by MatusGuy

Loading

bruhmoent left a comment •

edited

Loading

provigz commented Aug 27, 2025 •

edited

Loading