Optimizing FreeBSD Build#3603
Open
1111Windows wants to merge 73 commits into
Open
Conversation
Removed unused 'with' parameters from FreeBSD workflow.
Updated FreeBSD workflow to install dependencies and build.
Added bash installation to FreeBSD workflow and ensured bash is used in the build process.
Add installation of libraqm package for FreeBSD builds.
Updated FreeBSD CI workflow to include architecture and output directory changes.
FreeBSD VMs are connected via SSH, and it appears that variables are not passed.
I made a typo.
Contributor
Author
|
I've taken care of the rest, so we can merge now. |
swagtoy
requested changes
Feb 4, 2026
swagtoy
requested changes
Feb 4, 2026
swagtoy
force-pushed
the
master
branch
2 times, most recently
from
806ca6a to
c12b71b
Compare
swagtoy
requested changes
May 11, 2026
Member
swagtoy
left a comment
swagtoy
left a comment
There was a problem hiding this comment.
Apologies for the delay on reviewing this...
from SuperTuxKart-1.5-linux-arm64.tar.gz run_game.sh
Contributor
Author
No worries, I was thinking about whether I should let you know on Matrix when I commit today (I've actually been putting this PR on hold for a while now, haha) |
swagtoy
reviewed
May 12, 2026
| make install DESTDIR="./out" VERBOSE=1 | ||
| cd out/usr | ||
| echo -e '#!/bin/sh\n' 'export LD_LIBRARY_PATH=./lib/:$LD_LIBRARY_PATH\n' './bin/supertux2 "$@"' >> run.sh | ||
| echo -e '#!/bin/sh\nexport DIRNAME="$(dirname "$(readlink -f "$0")")"\nexport SYSTEM_LD_LIBRARY_PATH="$LD_LIBRARY_PATH"\ncd "$DIRNAME"\nexport LD_LIBRARY_PATH="$LD_LIBRARY_PATH:$DIRNAME/lib/"\n"$DIRNAME/bin/supertux2" "$@"' > run.sh |
Member
There was a problem hiding this comment.
nit: go back to space separating the \n via separate echo arguments
see if you can do \
this to make those multiline. It \
just aids in readibility :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is an improvement following #3513, and its changes are as follows:
2.Compress files directly in the build/out/usr folder to avoid requiring users to navigate to the out/usr folder when decompressing the files.
3.Resolve the issue: ld-elf.so.1: /usr/local/lib/libpcre2-8.so.0: version PCRE2_10.47 required by /usr/local/bin/git not defined.
4.Pass parameters to the program when running run.sh (if any).