Skip to content

add runner OS in cache key #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Swatinem merged 2 commits into from
Dec 9, 2024
Merged

add runner OS in cache key #220

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e89acd5
add runner OS in cache key
rnbguy Nov 29, 2024
342be2c
fix check-dist on ci
rnbguy Dec 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions dist/restore/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77314,6 +77314,9 @@ class CacheConfig {
key += `-${job}`;
}
}
// Add runner OS to the key to avoid cross-contamination of cache
const runnerOS = external_os_default().type();
key += `-${runnerOS}`;
self.keyPrefix = key;
// Construct environment portion of the key:
// This consists of a hash that considers the rust version
Expand Down
3 changes: 3 additions & 0 deletions dist/save/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77314,6 +77314,9 @@ class CacheConfig {
key += `-${job}`;
}
}
// Add runner OS to the key to avoid cross-contamination of cache
const runnerOS = external_os_default().type();
key += `-${runnerOS}`;
self.keyPrefix = key;
// Construct environment portion of the key:
// This consists of a hash that considers the rust version
Expand Down
4 changes: 4 additions & 0 deletions src/config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,10 @@ export class CacheConfig {
}
}

// Add runner OS to the key to avoid cross-contamination of cache
const runnerOS = os.type();
key += `-${runnerOS}`;

self.keyPrefix = key;

// Construct environment portion of the key:
Expand Down