Skip to content

[Maintenance] Refactor after bump to Sylius 2.0#452

Merged
GSadee merged 3 commits intoSylius:2.0from
mpysiak:SYL-3914-refactor
Nov 27, 2024
Merged

[Maintenance] Refactor after bump to Sylius 2.0#452
GSadee merged 3 commits intoSylius:2.0from
mpysiak:SYL-3914-refactor

Conversation

@mpysiak
Copy link
Member

@mpysiak mpysiak commented Nov 27, 2024

Q A
Branch? 2.0
Bug fix? no
New feature? no
Related tickets #437

@mpysiak mpysiak requested a review from a team as a code owner November 27, 2024 07:14
@GSadee GSadee added the Maintenance Configurations, READMEs, releases, etc. label Nov 27, 2024
from: [new]
to: completed No newline at end of file
to: completed

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

$this->grossValue = $grossValue;
$this->taxAmount = $taxAmount;
$this->taxRate = $taxRate;
public function __construct(protected string $name, protected int $quantity, protected int $unitNetPrice, protected int $unitGrossPrice, protected int $netValue, protected int $grossValue, protected int $taxAmount, protected ?string $taxRate = null)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Split into multiple lines, it applies also to the below entities

@GSadee GSadee merged commit f198376 into Sylius:2.0 Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Maintenance Configurations, READMEs, releases, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants