Merged
Conversation
casperdcl
requested review from
KrisThielemans,
evgueni-ovtchinnikov and
paskino
casperdcl
added
enhancement
SIRFReg
- fixes #1384
casperdcl
force-pushed
the
handle-everything
branch
2 times, most recently
from
5405662 to
87e63df
Compare
casperdcl
commented
Mar 26, 2026
casperdcl
force-pushed
the
handle-everything
branch
from
87e63df to
a8bf5e2
Compare
Member
Author
|
All tests passing; codacy can be ignored. 1k fewer lines :) |
KrisThielemans
approved these changes
Mar 27, 2026
Member
KrisThielemans
left a comment
KrisThielemans
left a comment
There was a problem hiding this comment.
fine for me. I didn't check the detail of course.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add
Utilities.Handlewrapper (fixes #1384)👉 diff sans whitespace
SIRFSTIRRegGadgetroncGT_getImageDimmissing try/catch/return