Conversation
TheKorpos
approved these changes
Jul 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes a small update to the
KerMLRepositorySaveUtil, additionally to the updates already made for the new capabilities in PR #633.The new capabilities in PR #633 included adding the
-poption for an explicit project name to which to save a model. If this option is not used, then a default project name is created based on the file name of the model being saved. As implemented in PR #633,KerMLRepositorySaveUtilalso still added the project creation timestamp to this default name, which is not consistent with the corresponding implementation of the Jupyter%publishcommand. The update in this PR is to remove the appending of the timestamp to the default project name.As updated, the default project name is now just the model file name with the extension part removed. The extension part is considered to be that part of the file name from the last dot character (
.) in the file name (if any) to the end of the file name. (Previously the computation used the first dot character, rather than the last, which incorrectly handled file names that included dots before the extension part.)