[#13484] Migrate frontend to use control flow syntax

[samuelfangjw]

Fixes #13484

Outline of Solution

1. Some errors after the migration process. These were due to existing issues in the codebase (wrong types mainly). See 5f43837 for full list of fixes.
2. For some reason the migration schematic missed out account-request-table. This was migrated manually.
3. The test snapshots have changes in whitespace, these are non-consequential as trailing and leading whitespace are stripped in html.
4. I've made a best effort attempt to clean up the control flow syntax (appropriate control flow blocks, appropriate key in for block if available).

[samuelfangjw]

Keeping this PR draft until I have reviewed it myself but it's largely good to go already.

[Copilot]

Pull request overview

This PR migrates the Angular frontend codebase from using structural directives (*ngIf, *ngFor) to Angular's new control flow syntax (@if, @for, @else). This is a major refactoring that modernizes the codebase to use Angular's built-in control flow features introduced in recent versions.

Changes:

• Replaced all *ngIf directives with @if blocks
• Replaced all *ngFor directives with @for loops using track expressions
• Removed imports of NgIf, NgFor, and NgTemplateOutlet from components that no longer need them
• Updated tracking functions to use inline $index instead of custom trackBy functions
• Updated comment in collapse-anim.ts to reflect the new syntax

Reviewed changes

Copilot reviewed 290 out of 345 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
Multiple .component.ts files	Removed unused Angular common module imports (NgIf, NgFor)
Multiple .component.html files	Converted structural directives to control flow syntax
collapse-anim.ts	Updated comment to reference conditional rendering instead of *ngIf
Multiple component files	Removed custom trackBy functions now handled by inline track expressions
instructor-role-name.pipe.ts	Added support for undefined role parameter
Various type definition files	Updated type definitions for better type safety
Test snapshot files	Whitespace changes in test snapshots (non-consequential)

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[samuelfangjw]

This will have significant conflicts with #13491 that will have to be de-conflicted.