fix fail test run with enabled junit.testFilter option#1361
fix fail test run with enabled junit.testFilter option#1361codecholeric merged 1 commit intoTNG:mainfrom
Conversation
|
Thanks a lot for taking care of this! I do have one suggestion that I added as a fixup (see the commit message for the reasoning). In a nutshell, I think we can solve it a little safer by checking |
|
BTW: To get throught the CI commits also need a DCO sign-off in your commit message (see https://github.com/TNG/ArchUnit/blob/main/DCO#L34). If you're fine with that I could also add the line for you if you want 😉 |
|
Hi! I'm sorry for the long wait.
Thank you, I agree with your suggestion, it looks like more general decision
I would be very grateful to you. |
d42985a to
dd87277
Compare
Before if everything was filtered out the filter also tried to remove the root descriptor which then failed with ``` Caused by: org.junit.platform.commons.PreconditionViolationException: cannot remove the root of a hierarchy ``` Signed-off-by: Ilya Safonov <breakjessy@gmail.com>
dd87277 to
ba0b287
Compare
Hi! There is a problem if you enable the
junit.testFiltersetting, and there are other tests in the project besides arch-unitException:
In PR fix a condition so that non-ArchUnit descriptors are not checked
Tested the changes in my test repository https://github.com/Sparkymann/archunit-test
Failed workflow: https://github.com/Sparkymann/archunit-test/pull/1/checks
Corrected: https://github.com/Sparkymann/archunit-test/pull/3/checks