Fix external link handling in SimpleLinkService#221
Merged
Conversation
- validate URL before assigning to anchor - restrict protocols to http/https/mailto/tel - support newWindow parameter - add configurable externalLinkTarget and externalLinkRel
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working with vue-pdf I noticed that external links rendered from PDFs did not set
targetandrelattributes on the generated anchor elements. This stemmed from an empty implementation ofaddLinkAttributesinSimpleLinkService.This PR implements the following improvements:
newWindowparameterexternalLinkTargetandexternalLinkRelwindowis unavailableBuild and tests pass locally. Tested locally with PDFs containing external hyperlinks.