[codex] Add Solid Start pending hydration regression test

[ljho01]

What changed

This adds a Solid Start regression test for ssr: 'data-only' with a slow loader and a pendingComponent that returns a DOM element.

It introduces:

• a dedicated /mre-data-only route under e2e/solid-start/selective-ssr
• a dev-only Playwright config so the hydration path is exercised against the Vite dev server
• a focused Playwright spec that asserts the route hydrates through pending and reaches OK — loader finished without template is not a function or Hydration Mismatch

Why

This is intended to lock in the Solid hydration fix around pendingComponent on data-only routes.

Current main passes this test.
If packages/solid-router/src/Match.tsx is changed from:

(isServer ?? router.isServer) || resolvedNoSsr

to:

(isServer ?? router.isServer) && resolvedNoSsr

the same test fails in dev mode and the route never reaches the loaded UI.

Impact

This gives us a targeted regression test for the exact hydration behavior that previously broke in dev mode for Solid Start.

Validation

Ran:

cd e2e/solid-start/selective-ssr
rm -rf port*.txt && pnpm exec playwright test --config=playwright.dev.config.ts tests/pending-component-hydration.spec.ts --project=chromium

Also manually verified:

• current main / fixed || condition: passes
• local temporary revert to &&: fails
• restored ||: passes again

[coderabbitai]

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 40c5d808-9dab-455e-85f5-f42d5c60e7fa

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}