Repository navigation
fix(seats): Hermes refuses in plain words (F116) - #4125
Open
lilyshen0722 wants to merge 2 commits into
Open
lilyshen0722 wants to merge 2 commits into
lilyshen0722 wants to merge 2 commits into
Conversation
Hermes's refusals reach the person attaching their own agent, and they read as operator notes: 'no enforced confinement adapter exists', 'through Secret Manager', 'environment.provider'. Each now says what Hermes needs and what to do: Commonly has no sandbox for Hermes yet (public seat, or a sandbox mode, named), and Hermes connects through OpenRouter only (provider block, or a missing OPENROUTER_API_KEY). The checks themselves are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01N4VWLDwn18YFTTgyP91mNW
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 57 seconds. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
… (F116 review) providerRefusal runs before validateEnvironment at attach, run and the daemon's swap, so a Hermes provider block still got 'requires a provider-capable adapter'. An adapter that takes no provider block may now name its own refusal (noProviderRefusal); Hermes uses its plain text and every other adapter keeps the shared message. The environment.mcp refusal is plain too. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01N4VWLDwn18YFTTgyP91mNW
lilyshen0722
commented
Nov 14, 2026
lilyshen0722
left a comment
Contributor
Author
There was a problem hiding this comment.
One review round (Tier 1: Sonnet, effort medium). The reviewer read REVIEW.md and checked logic, truth of the wording, where each message is shown, and the tests.
Round 1 at 960431a: HOLD.
- The CLI's shared
providerRefusalruns beforevalidateEnvironmentat attach, so a Hermes provider block still got "requires a provider-capable adapter". The new provider text never reached the person, and the matrix line overclaimed. - Low: the
environment.mcprefusal was still jargon. - Checked clean:
- the split public/sandbox check is exactly equivalent, so nothing new passes;
sandbox.modeinterpolation is enum-bounded and local;- pod turn-failure notices use fixed strings, so nothing leaks into a pod and classification is unchanged;
- no other test or doc quotes the old strings.
Round 2 at d136629: PASS.
providerRefusalreturnsadapter.noProviderRefusalonly for an adapter without provider support that sets it. Every other adapter keeps the shared message.- The check runs at attach, run and the daemon swap, so all three paths now use the plain wording.
HERMES_NO_PROVIDERis one const shared withvalidateEnvironment, so the two can't drift.- The
mcprefusal is plain and true. Hermes gets no default MCP, so only a person's own block hits it. - The matrix line is accurate.
- 34/34 in the Hermes and seats-package files.
Nit, open: noProviderRefusal isn't listed in the adapter contract doc.
GATE: PASS
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A person who attached Hermes as their own agent got refusals worded as operator notes. Growth's 11-04 harness walk found Hermes 0.22.5 refused at attach. F116 keeps that refusal and makes it plain.
Before and after
mcpblockThe checks themselves are unchanged. The single public-or-sandbox check is split in two so each can name its own reason.
The CLI's shared provider check (
providerRefusal) runs before the adapter's own check at attach, at run and in the daemon's adapter swap, so it used to answer a Hermes provider block with "requires a provider-capable adapter". An adapter that takes no provider block can now name its own refusal (noProviderRefusal). Hermes does, and every other adapter keeps the shared message.Tests
cli/__tests__/adapters.hermes.test.mjsadds a test that every refusal is plain, with no internal names, and one for the missing-key message.seats-package.test.mjs.Docs
The Hermes row in
docs/agents/byo-support-matrix.mdnow says what is refused at attach, and why.packages/seatsis bundled into the CLI tarball, so a merge publishes the CLI to@latest. Press it in the post-PH cli window. Tier 1. Sonnet review: HOLD at 960431a (the shared provider check answered first, so the new provider text never reached attach), fixed at d136629.🤖 Generated with Claude Code
https://claude.ai/code/session_01N4VWLDwn18YFTTgyP91mNW