Skip to content

[FEAT/#102] OurTodo / 초대코드 다이얼로그 구현#107

Merged
Marchbreeze merged 7 commits intodevelopfrom
feat/#102-todo-invite-dialog
Jan 14, 2024
Merged

[FEAT/#102] OurTodo / 초대코드 다이얼로그 구현#107
Marchbreeze merged 7 commits intodevelopfrom
feat/#102-todo-invite-dialog

Conversation

@Marchbreeze
Copy link
Member

⛳️ Work Description

  • 초대코드 인텐트로 넘기기
  • 다이얼로그 UI 설정

📸 Screenshot

KakaoTalk_Video_2024-01-14-23-35-13.mp4

📢 To Reviewers

  • 아좌좌

@Marchbreeze Marchbreeze requested review from chattymin, crownjoe and leeeyubin and removed request for crownjoe and leeeyubin January 14, 2024 14:36
@Marchbreeze Marchbreeze self-assigned this Jan 14, 2024
@Marchbreeze Marchbreeze added 상호 🍀 FEAT ✨ 새로운 기능 구현 labels Jan 14, 2024
@crownjoe crownjoe requested a review from leeeyubin January 14, 2024 14:52
Copy link
Contributor

@crownjoe crownjoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

역시 갓상호 수고하셧습니다!!!!!!!

Comment on lines +150 to +152
app:layout_constraintHorizontal_chainStyle="packed"
app:layout_constraintStart_toStartOf="parent"
app:layout_constraintTop_toTopOf="@id/tv_finish_trip_terms_text" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수정해주셔서 감사합니다..........꾸벅

Comment on lines +55 to +60
val clipboardManager =
requireContext().getSystemService(Context.CLIPBOARD_SERVICE) as ClipboardManager
val clipData = ClipData.newPlainText(CLIP_LABEL, inviteCode)
clipboardManager.setPrimaryClip(clipData)
if (Build.VERSION.SDK_INT <= Build.VERSION_CODES.S_V2) toast(getString(R.string.finish_trip_tv_copy_code_complete))
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

클립보드 복사! 좋아욥

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

스트링으로 빼면 더 좋을 것 같숩니다!

Copy link
Member

@chattymin chattymin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

나아아아아중에 시간되면 string 추출해줘용~
앱잼 평가기준임!!

@Marchbreeze Marchbreeze merged commit 70be909 into develop Jan 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FEAT ✨ 새로운 기능 구현 상호 🍀

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEAT] OurTodo / 초대코드 다이얼로그 구현

3 participants

Comments