Conversation
…into add/#1-project-setting
b1urrrr
reviewed
Dec 27, 2023
Comment on lines
+22
to
+24
| private fun setDayMode() { | ||
| AppCompatDelegate.setDefaultNightMode(AppCompatDelegate.MODE_NIGHT_NO) | ||
| } |
There was a problem hiding this comment.
크 함수화 깔끔하다 👍
당분간 다크모드를 개발할 계획이 없다면 themes.xml (night) 로 분기 처리되어 있는 파일을 아예 제거하는 방법도 있습니당
kkk5474096
reviewed
Dec 28, 2023
Comment on lines
64
to
86
| KotlinDependencies.run { | ||
| implementation(kotlin) | ||
| implementation(coroutines) | ||
| implementation(jsonSerialization) | ||
| implementation(dateTime) | ||
| } | ||
|
|
||
| AndroidXDependencies.run { | ||
| implementation(coreKtx) | ||
| implementation(appCompat) | ||
| implementation(constraintLayout) | ||
| implementation(fragment) | ||
| implementation(startup) | ||
| implementation(legacy) | ||
| implementation(security) | ||
| implementation(hilt) | ||
| implementation(lifeCycleKtx) | ||
| implementation(lifecycleJava8) | ||
| implementation(splashScreen) | ||
| implementation(pagingRuntime) | ||
| implementation(workManager) | ||
| implementation(hiltWorkManager) | ||
| } |
There was a problem hiding this comment.
app module에 있는 라이브러리 의존성들과 presentation에 있는 라이브러리 의존성들이 중복으로 사용되는 부분이 많은데
해당 중복부분을 제거해서 하나로 사용하는 방법을 고민해봐도 좋을 듯~
Member
Author
There was a problem hiding this comment.
app 모듈은 presentation 의 의존성을 모두 가져올 수 있으니, 아예 presentation에서만 implementation을 관리하면 될까용?
Comment on lines
+40
to
+62
| KotlinDependencies.run { | ||
| implementation(kotlin) | ||
| implementation(coroutines) | ||
| implementation(jsonSerialization) | ||
| implementation(dateTime) | ||
| } | ||
|
|
||
| AndroidXDependencies.run { | ||
| implementation(coreKtx) | ||
| implementation(appCompat) | ||
| implementation(constraintLayout) | ||
| implementation(fragment) | ||
| implementation(startup) | ||
| implementation(legacy) | ||
| implementation(security) | ||
| implementation(hilt) | ||
| implementation(lifeCycleKtx) | ||
| implementation(lifecycleJava8) | ||
| implementation(splashScreen) | ||
| implementation(pagingRuntime) | ||
| implementation(workManager) | ||
| implementation(hiltWorkManager) | ||
| } |
There was a problem hiding this comment.
중복 내용은 위와 동일~
그리고 presentation 모듈을 나눴다는건 feature 별로 안에 하위 모듈들을 추가로 나누어서 진행하는 것으로 알면 될까요?.?
그래야 나눈것에 대한 이점이 있다고 생각합니다~
Member
Author
There was a problem hiding this comment.
feature들까지 모듈화하면 너무 어려워질 것 같아서,,, 우선은 presentation 모듈을 만들어두는 것까지만 해보려구용
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
⛳️ Work Description
📸 Screenshot
📢 To Reviewers