Merged
Conversation
crownjoe
approved these changes
Jan 9, 2024
Contributor
crownjoe
left a comment
crownjoe
left a comment
There was a problem hiding this comment.
아 그는 데바"도" 마스터네요
갓상호 멋진 코드 읽고 갑니다
따봉 👍👍👍👍👍👍👍👍👍👍
app/src/main/AndroidManifest.xml
Outdated
Contributor
There was a problem hiding this comment.
pr 올릴 때 true 말고 false 부탁드립니다~!
Comment on lines
+27
to
+32
| private fun initFinishBtnClickListener() { | ||
| binding.btnCreateTripFinish.setOnSingleClickListener { | ||
| viewModel.endDate.value = | ||
| binding.dpCreateTripDate.year.toString() + "." + (binding.dpCreateTripDate.month + 1).toString() + "." + binding.dpCreateTripDate.dayOfMonth.toString() | ||
| viewModel.checkIsFinishAvailable() | ||
| dismiss() |
|
|
||
| </androidx.constraintlayout.widget.ConstraintLayout> | ||
|
|
||
| </ScrollView> |
| <style name="TextAppearance.Doorip" parent=""> | ||
| <item name="android:textStyle">normal</item> | ||
| <item name="android:textColor">@color/black_000</item> | ||
| <item name="android:textColor">@color/gray_700</item> |
leeeyubin
approved these changes
Jan 9, 2024
Member
leeeyubin
left a comment
leeeyubin
left a comment
There was a problem hiding this comment.
완벽하십니다,, 다음에도 눈 키고 찾아볼게요 ㅎㅅㅎ
Comment on lines
5
to
7
| <item name="android:textStyle">normal</item> | ||
| <item name="android:textColor">@color/black_000</item> | ||
| <item name="android:textColor">@color/gray_700</item> | ||
| <item name="android:textAllCaps">false</item> |
Comment on lines
+280
to
+283
| android:paddingVertical="10dp" | ||
| android:text="@string/my_todo_create_btn_finish" | ||
| android:textColor="@{vm.isFinishAvailable() == true ? @color/white_000 : @color/gray_200}" | ||
| android:textSize="16sp" |
chattymin
approved these changes
Jan 9, 2024
app/src/main/AndroidManifest.xml
Outdated
Member
There was a problem hiding this comment.
세연이가 화가 많이 났습니다...
false로 바꿔서 올려주세용...
Comment on lines
+29
to
+31
| viewModel.endDate.value = | ||
| binding.dpCreateTripDate.year.toString() + "." + (binding.dpCreateTripDate.month + 1).toString() + "." + binding.dpCreateTripDate.dayOfMonth.toString() | ||
| viewModel.checkIsFinishAvailable() |
Member
There was a problem hiding this comment.
string 리소스 내부 변수를 활용해서 나타낸다면 더 좋을 것 같아요~
string 리소스를 "%1d.%2d.%3d"이렇게 두고 해당 값들을 변수로 넣으면 좋을 것 같네용!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
⛳️ Work Description
📸 Screenshot
KakaoTalk_Video_2024-01-09-23-39-47.mp4
📢 To Reviewers