Merged
Conversation
Marchbreeze
approved these changes
Jan 12, 2024
Member
Marchbreeze
left a comment
Marchbreeze
left a comment
There was a problem hiding this comment.
이유빈 선생님 늦은 시간까지 고생이 참 많으십니다.
Comment on lines
11
to
12
| ) : DashBoardDataSource { | ||
| override suspend fun getTripList(progress: String): BaseResponse<DashBoardResponseDto> = |
Comment on lines
32
to
35
Comment on lines
+9
to
+10
| private val dashBoardSource: DashBoardDataSource | ||
| ) : DashBoardRepository { |
Member
There was a problem hiding this comment.
이렇 중요한 텍스트는 const val로 관리해주시면 좋을 것 같아요 ~
Member
There was a problem hiding this comment.
아래 뷰모델에서 지정을 해줬으니, 그거 가져와서 임포트 하시는게 더 좋을 듯
Comment on lines
52
to
53
chattymin
reviewed
Jan 12, 2024
Member
chattymin
left a comment
chattymin
left a comment
There was a problem hiding this comment.
유비니 첫 api 통신 축하축하!!!
근데 empty일때도 뷰 보고시퍼용... 담엔 같이 올려주기~
Member
There was a problem hiding this comment.
width를 wrapcontent로 하고 start와 end를 parent로 맞춰준다면 gravity center 안써도 될 것 같아용~
crownjoe
approved these changes
Jan 12, 2024
Contributor
crownjoe
left a comment
crownjoe
left a comment
There was a problem hiding this comment.
역시 유빈지노 이걸 해내네~ 남은 서버통신도 파이팅하요!
Comment on lines
32
to
34
| interface DashBoardService { | ||
| @GET("api/trips") | ||
| suspend fun getTripList( | ||
| @Query("progress") progress: String |
| <!--trip_dash_board--> | ||
| <string name="dashboard_tv_title">%s님의 여행</string> | ||
| <string name="dashboard_tv_empty">생성된 여행이 없어요.</string> | ||
| <string name="dashboard_tv_empty">새로운 여행을 시작해 보세요</string> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
⛳️ Work Description
📸 Screenshot
default.mp4
📢 To Reviewers