Skip to content

[FEAT/#86] 여행 생성 뷰 #91

Merged
crownjoe merged 3 commits intodevelopfrom
feat/#86-create-trip-api
Jan 12, 2024
Merged

[FEAT/#86] 여행 생성 뷰 #91
crownjoe merged 3 commits intodevelopfrom
feat/#86-create-trip-api

Conversation

@crownjoe
Copy link
Contributor

@crownjoe crownjoe commented Jan 12, 2024

⛳️ Work Description

  • createtrip 뷰에서 사용자가 입력한 여행 제목, 여행 시작(년월일), 여행 종료(년월일)을 다음 뷰에 넘김(값 확인완료)
  • 성향 태그 뷰 생성 (유빈이가 리사이클러뷰 수정 후 붙일 예정)

@crownjoe crownjoe added 세연 🤤 FEAT ✨ 새로운 기능 구현 labels Jan 12, 2024
@crownjoe crownjoe self-assigned this Jan 12, 2024
Copy link
Member

@chattymin chattymin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

조와요~

Comment on lines 177 to 189
binding.btnCreateTripNext.setOnSingleClickListener {
//다음으로 넘어감
Intent(this, PreferenceTagActivity::class.java).apply {
putExtra(NAME, viewModel.name.value)
putExtra(START, viewModel.startYear.value)

putExtra(START, viewModel.startMonth.value)
putExtra(START, viewModel.startDay.value)
putExtra(END, viewModel.endYear.value)
putExtra(END, viewModel.endMonth.value)
putExtra(END, viewModel.endDay.value)
startActivity(this)
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intent에서 class를 넘겨줄때는 Parcelable을 적용해보는건 어떨까요?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

넵 구현 다 하고 적용해보겟습뉘다

Copy link
Member

@leeeyubin leeeyubin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

빠른 PR 감사합니둥

Comment on lines +1 to +4
package com.going.presentation.enter

class FinishPreferenceActivity {
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 파일이 여행 입장할 때 쓰일 취향 태그 있는 액티비티인가용?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

넵 맞숩니당

@crownjoe crownjoe merged commit 0124b7c into develop Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FEAT ✨ 새로운 기능 구현 세연 🤤

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEAT] 여행 입장 뷰 / 서버 통신 구현

3 participants

Comments