[FEAT/#89] MyTodo 미완료, 완료 / 서버통신 구현#97
Merged
Marchbreeze merged 15 commits intodevelopfrom Jan 14, 2024
Merged
Conversation
…into feat/#89-my-todo-finish
Marchbreeze
requested review from
chattymin,
crownjoe and
leeeyubin
and removed request for
crownjoe and
leeeyubin
…into feat/#89-my-todo-finish
leeeyubin
approved these changes
Jan 12, 2024
Member
leeeyubin
left a comment
leeeyubin
left a comment
There was a problem hiding this comment.
좋아여좋아여좋아여 건들 곳이 없네여,,쳇 최고다!
Comment on lines
+66
to
+68
| putIntegerArrayListExtra(EXTRA_PARTICIPANT_ID, idList) | ||
| putStringArrayListExtra(EXTRA_NAME, nameList) | ||
| putIntegerArrayListExtra(EXTRA_RESULT, resultList) |
| day > 0 -> { | ||
| binding.tvOurTodoTitleDown.text = getString(R.string.our_todo_title_down_before).format(day) | ||
| binding.tvOurTodoTitleDown.text = | ||
| getString(R.string.our_todo_title_down_before).format(day) |
| nowMemoLength.value = getGraphemeLength(memo.value) | ||
| isFinishAvailable.value = | ||
| todo.value?.isNotEmpty() == true && endDate.value?.isNotEmpty() == true | ||
| todo.value?.isNotEmpty() == true && endDate.value?.isNotEmpty() == true && participantList.any { it.isSelected } |
Member
There was a problem hiding this comment.
우아 배열에도 이런 식으로 쓸 수가 있더라구여..?! 신기방기
crownjoe
approved these changes
Jan 12, 2024
Contributor
crownjoe
left a comment
crownjoe
left a comment
There was a problem hiding this comment.
멋진 코드들 잘 보고 갑니당
역시 그는 갓!
Comment on lines
55
to
56
| { todoModel -> | ||
| if (todoModel.allocators.size <= 1) { |
| fun onBind(item: TodoModel) { | ||
| binding.run { | ||
| tvMyTodoItemTitle.text = item.title | ||
| tvMyTodoItemDate.text = item.endDate.replace("-", ".") + "까지" |
Contributor
There was a problem hiding this comment.
오! 요것도 지금 봤는데 이렇게 하면 깔끔하게 할 수 있군ㅇ뇨
| val nameList = intent.getStringArrayListExtra(EXTRA_NAME)?.toList() ?: listOf() | ||
| val resultList = intent.getIntegerArrayListExtra(EXTRA_RESULT)?.toList() ?: listOf() | ||
| viewModel.totalParticipantList = | ||
| idList.zip(nameList).zip(resultList) { (id, name), result -> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
⛳️ Work Description
📸 Screenshot
KakaoTalk_Video_2024-01-13-04-11-37.mp4
📢 To Reviewers
남은거는