feat: 서재UI/UX 개편 (7) - API 마이그레이션 및 기존 코드 제거 by s9hn · Pull Request #710 · Team-WSS/WSS-Android

s9hn · 2025-06-02T07:04:17Z

📌𝘐𝘴𝘴𝘶𝘦𝘴

closed feat: 서재UI/UX 개편 (7) - API 마이그레이션 및 기존 코드 제거 #701

📎𝘞𝘰𝘳𝘬 𝘋𝘦𝘴𝘤𝘳𝘪𝘱𝘵𝘪𝘰𝘯

새로운 서재API를 적용했습니다.
OtherUserActivity, LibraryFragment의 기존 코드를 제거했습니다.
앞으로 구현될 ComposeView로 구현될 예정입니다.

💬𝘛𝘰 𝘙𝘦𝘷𝘪𝘦𝘸𝘦𝘳𝘴

현재는 간단한 로컬 페이징만 구현되어 있습니다.
다음 이슈인 리모트-페이징 구현을 위해 임시로 LocalDataSource쪽을 주석처리 해놓았습니다.
룸 캐싱은 추후 이슈에서 다룰 예정입니다.

…to feat/701

coderabbitai · 2025-06-02T07:04:22Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

m6z1

paging 도 버전 카탈로그 적용 부탁드립니다!

m6z1 · 2025-06-03T07:23:20Z

app/build.gradle.kts

    implementation(libs.firebase.analytics)
    implementation(libs.firebase.messaging)
+
+    implementation("androidx.paging:paging-runtime:3.3.2")


r: 얘도 버전 카탈로그 이용해서 관리부탁드립니다

m6z1 · 2025-06-03T07:26:54Z

data/library/build.gradle.kts

 }

 dependencies {
+    implementation("androidx.paging:paging-runtime:3.3.2")


r: 여기두

m6z1 · 2025-06-03T07:28:41Z

domain/library/build.gradle.kts

+
+dependencies {
+    implementation(projects.data.library)
+    implementation("androidx.paging:paging-runtime:3.3.2")


m6z1 · 2025-06-03T07:29:06Z

feature/library/build.gradle.kts

-    implementation(projects.data.library)
+    implementation(projects.domain.library)
+
+    implementation("androidx.paging:paging-runtime:3.3.2")


yeonjeen

수고하셨습니다!!

s9hn added 15 commits May 19, 2025 21:06

refactor: LibraryLocalDataSource 명세 재정의

e6c6639

refactor: LibraryLocalDataSource 구현

806ec2a

refactor: InDatabaseNovelEntity 추가 및 적용

99abf1d

refactor: 기존 getUserStorage API 마이그레이션

ed7b192

feat: InMemory 캐싱 데이터소스 구현

ba94b0b

build: 페이징 의존성 추가

c56f3c0

Merge branch 'feat/704' of https://github.com/Team-WSS/WSS-Android in…

bb6aa75

…to feat/701

feat: 기존 서재뷰 페이징 라이브러리 적용

cf70669

refactor: db 힐트 모듈 일원화

185cf7c

refactor: 주석 제거

25c5992

feat: LibraryRemoteMediator 구현

8d4b6c4

build: 피쳐모듈 페이징 의존성 추가

93e3946

build: 피쳐모듈 페이징 의존성 추가

1bfdb88

build: 피쳐모듈 페이징 의존성 추가

67b6387

build: 피쳐모듈 페이징 의존성 추가

2818567

github-actions bot assigned s9hn Jun 2, 2025

github-actions bot requested review from junseo511, m6z1 and yeonjeen June 2, 2025 07:04

s9hn added 10 commits June 3, 2025 14:49

refactor: 기존 코드 제거 및 컴포즈로 마이그레이션

3ae7a7b

build: 서재 도메인 레이어 추가

5152a67

feat: 도메인 모델 및 유즈케이스 구현

1764801

refactor: 네트워크 레이어 API 마이그레이션

96b0b7c

refactor: DefaultLibraryLocalDataSource 제거

7e1a110

refactor: data 레이어 API 마이그레이션 반영

5701608

refactor: 임시 주석처리

3095793

feat: 서재 불러오기 유즈케이스 연결

4423d80

feat: 서재 불러오기 피쳐 임시 연결

9eb1501

refactor: 컴파일 에러 해결

4f3ffea

refactor: UserStorageActivity 컴포즈 마이그레이션 및 불필요한 코드 제거

4348813

s9hn changed the base branch from feat/669 to feat/704 June 3, 2025 07:17

s9hn changed the title ~~Feat/701~~ feat: 서재UI/UX 개편 (7) - API 마이그레이션 및 기존 코드 제거 Jun 3, 2025

m6z1 approved these changes Jun 3, 2025

View reviewed changes

yeonjeen approved these changes Jun 3, 2025

View reviewed changes

s9hn merged commit c5e90f8 into feat/704 Jun 4, 2025
1 check passed

m6z1 added 🍯 [FEAT] 새로운 기능을 개발합니다. ⚖️ 재상 세훈 전지적 세훈 시점 labels Jun 26, 2025

m6z1 deleted the feat/701 branch August 11, 2025 15:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: 서재UI/UX 개편 (7) - API 마이그레이션 및 기존 코드 제거#710

feat: 서재UI/UX 개편 (7) - API 마이그레이션 및 기존 코드 제거#710
s9hn merged 26 commits intofeat/704from
feat/701

s9hn commented Jun 2, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Jun 2, 2025

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

m6z1 left a comment

Uh oh!

m6z1 Jun 3, 2025

Uh oh!

m6z1 Jun 3, 2025

Uh oh!

m6z1 Jun 3, 2025

Uh oh!

m6z1 Jun 3, 2025

Uh oh!

yeonjeen left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

s9hn commented Jun 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📌𝘐𝘴𝘴𝘶𝘦𝘴

📎𝘞𝘰𝘳𝘬 𝘋𝘦𝘴𝘤𝘳𝘪𝘱𝘵𝘪𝘰𝘯

💬𝘛𝘰 𝘙𝘦𝘷𝘪𝘦𝘸𝘦𝘳𝘴

Uh oh!

coderabbitai bot commented Jun 2, 2025

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

m6z1 left a comment

Choose a reason for hiding this comment

Uh oh!

m6z1 Jun 3, 2025

Choose a reason for hiding this comment

Uh oh!

m6z1 Jun 3, 2025

Choose a reason for hiding this comment

Uh oh!

m6z1 Jun 3, 2025

Choose a reason for hiding this comment

Uh oh!

m6z1 Jun 3, 2025

Choose a reason for hiding this comment

Uh oh!

yeonjeen left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

s9hn commented Jun 2, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)