Conversation
Walkthrough문의하기 링크를 기존의 Changes
Assessment against linked issues
Possibly related PRs
Suggested reviewers
Poem
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
app/src/main/java/com/into/websoso/ui/detailExplore/keyword/DetailExploreKeywordFragment.kt(2 hunks)app/src/main/java/com/into/websoso/ui/novelRating/NovelRatingKeywordBottomSheetDialog.kt(2 hunks)core/resource/src/main/res/values/deepLinks.xml(0 hunks)
💤 Files with no reviewable changes (1)
- core/resource/src/main/res/values/deepLinks.xml
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: build
🔇 Additional comments (2)
app/src/main/java/com/into/websoso/ui/detailExplore/keyword/DetailExploreKeywordFragment.kt (1)
29-29: 리소스 이름 교체는 문제없으나 실제 values XML에 정의되어 있는지 확인 필요
inquire_link문자열 리소스가 values 파일에 누락되면 컴파일 에러가 발생합니다. 머지 전 한 번 더 리소스 존재 여부를 확인해 주세요.app/src/main/java/com/into/websoso/ui/novelRating/NovelRatingKeywordBottomSheetDialog.kt (1)
29-29: 리소스 교체 확인
inquire_link로 교체된 부분은 문제 없어 보입니다. 다만 build 시 리소스 누락 여부를 다시 한 번 점검해 주세요.
Comment on lines
73
to
76
| tracker.trackEvent("contact_keyword") | ||
| val inquireUrl = getString(kakao_channel_link) | ||
| val inquireUrl = getString(inquire_link) | ||
| val intent = Intent(Intent.ACTION_VIEW, Uri.parse(inquireUrl)) | ||
| startActivity(intent) |
There was a problem hiding this comment.
🛠️ Refactor suggestion
startActivity 호출 전 처리 가능 앱 존재 여부를 검증해야 합니다
외부 URL을 열 수 있는 앱이 단말에 없을 경우 ActivityNotFoundException 이 발생할 수 있습니다. 아래와 같이 resolveActivity 로 안전-가드를 추가해 주세요.
- val inquireUrl = getString(inquire_link)
- val intent = Intent(Intent.ACTION_VIEW, Uri.parse(inquireUrl))
- startActivity(intent)
+ val inquireUrl = getString(inquire_link)
+ val intent = Intent(Intent.ACTION_VIEW, Uri.parse(inquireUrl))
+ intent.resolveActivity(requireContext().packageManager)?.let {
+ startActivity(intent)
+ } ?: run {
+ // TODO: 사용자에게 링크를 열 수 없음을 안내
+ }📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| tracker.trackEvent("contact_keyword") | |
| val inquireUrl = getString(kakao_channel_link) | |
| val inquireUrl = getString(inquire_link) | |
| val intent = Intent(Intent.ACTION_VIEW, Uri.parse(inquireUrl)) | |
| startActivity(intent) | |
| tracker.trackEvent("contact_keyword") | |
| val inquireUrl = getString(inquire_link) | |
| val intent = Intent(Intent.ACTION_VIEW, Uri.parse(inquireUrl)) | |
| intent.resolveActivity(requireContext().packageManager)?.let { | |
| startActivity(intent) | |
| } ?: run { | |
| // TODO: 사용자에게 링크를 열 수 없음을 안내 | |
| } |
🤖 Prompt for AI Agents
In
app/src/main/java/com/into/websoso/ui/detailExplore/keyword/DetailExploreKeywordFragment.kt
around lines 73 to 76, before calling startActivity with the intent to open an
external URL, check if there is an app available to handle the intent using
resolveActivity. If no app can handle the intent, avoid calling startActivity to
prevent ActivityNotFoundException. Add this safety check to ensure the app does
not crash when no suitable app is installed.
Comment on lines
+94
to
96
| val inquireUrl = getString(inquire_link) | ||
| val intent = Intent(ACTION_VIEW, Uri.parse(inquireUrl)) | ||
| startActivity(intent) |
There was a problem hiding this comment.
🛠️ Refactor suggestion
안전하지 않은 startActivity 호출
BottomSheet 에서도 동일한 크래시 가능성이 존재합니다. 예외 방지를 위해 아래와 같이 수정하는 것을 권장드립니다.
- val inquireUrl = getString(inquire_link)
- val intent = Intent(ACTION_VIEW, Uri.parse(inquireUrl))
- startActivity(intent)
+ val inquireUrl = getString(inquire_link)
+ val intent = Intent(ACTION_VIEW, Uri.parse(inquireUrl))
+ intent.resolveActivity(requireContext().packageManager)?.let {
+ startActivity(intent)
+ } ?: run {
+ // TODO: Toast 등으로 사용자에게 안내
+ }🤖 Prompt for AI Agents
In
app/src/main/java/com/into/websoso/ui/novelRating/NovelRatingKeywordBottomSheetDialog.kt
around lines 94 to 96, the startActivity call is unsafe and may cause a crash if
no activity can handle the intent. To fix this, check if there is an activity
available to handle the intent before calling startActivity by using
packageManager.resolveActivity or a similar method, and only call startActivity
if it is safe to do so.
s9hn
approved these changes
Jun 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌𝘐𝘴𝘴𝘶𝘦𝘴
📎𝘞𝘰𝘳𝘬 𝘋𝘦𝘴𝘤𝘳𝘪𝘱𝘵𝘪𝘰𝘯
카카오톡 채널 > 노션 문의하기로 수정했습니다.📷𝘚𝘤𝘳𝘦𝘦𝘯𝘴𝘩𝘰𝘵
[키워드_상세탐색]
_.webm
[키워드_작품평가]
_.webm
💬𝘛𝘰 𝘙𝘦𝘷𝘪𝘦𝘸𝘦𝘳𝘴
Summary by CodeRabbit
버그 수정
정리