feat: 서재UI/UX 개편 (12) - 3차 QA 반영 by yeonjeen · Pull Request #729 · Team-WSS/WSS-Android

yeonjeen · 2025-07-27T14:42:29Z

📌𝘐𝘴𝘴𝘶𝘦𝘴

closed feat: 서재UI/UX 개편 (12) - 3차 QA 반영 #727

📎𝘞𝘰𝘳𝘬 𝘋𝘦𝘴𝘤𝘳𝘪𝘱𝘵𝘪𝘰𝘯

디자인 QA 사항 적용
필터 검색 결과 없는 경우의 null 화면 적용
스트링 리소스 하드코딩으로 전환

📷𝘚𝘤𝘳𝘦𝘦𝘯𝘴𝘩𝘰𝘵

💬𝘛𝘰 𝘙𝘦𝘷𝘪𝘦𝘸𝘦𝘳𝘴

# Conflicts: # feature/library/src/main/java/com/into/websoso/feature/library/LibraryScreen.kt # feature/library/src/main/java/com/into/websoso/feature/library/component/LibraryFilterBottomSheet.kt # feature/library/src/main/res/values/string.xml

coderabbitai · 2025-07-27T14:42:35Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch feat/727

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai generate unit tests to generate unit tests for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

s9hn

고생했어유

s9hn · 2025-07-27T15:53:12Z

feature/library/src/main/java/com/into/websoso/feature/library/model/LibraryUiState.kt

+    val isFilterApplied: Boolean
+        get() = readStatuses.values.any { it } ||
+                attractivePoints.values.any { it } ||
+                isRatingSelected ||
+                isInterested
+


c: 이거 LibraryViewModel에서 filter collect하는 부분에 filter 가 null이 아닐때 조건식 있는데 거기서 그냥 true세팅해주면 될듯 !

필터 검색에 필요한 필드들이 대부분 기본값을 가지고 있는 구조라서 말씀해주신 것처럼 단순히 true만 설정하게 될 경우 필터 검색 null 화면과 일반 서재 null화면을 분기처리하는 것에 어려움이 있습니다!! 그래서 이 방법도 결국 필터가 적용되어있는지를 판단하는 로직이 필요해서 현재 구조를 유지하는게 더 낫다고 생각합니다!

아아 맞네요 굿

yeonjeen added 14 commits July 22, 2025 00:30

refactor: 서재 empty 화면 간격 조정

27255e3

refactor: 날짜 노출 형태 변경

7d03971

feat: 읽기 상태 사이에 divider 추가

356bac6

feat: 필터 검색 결과가 없는 경우 컴포저블 함수 구현

d070dcb

refactor: 리스트 전환 아이콘 크기 수정

6ac43dc

refactor: 시스템 상태바, 서재 제목, 필터탑바 사이 간격 조정

5f4a6db

refactor: 읽기 상태 텍스트 길이에 따라 벳지 크기가 달라지는 현상 수정

9584751

add: 서재 리스트 아이콘 변경

6987bd8

refactor: 서재 스크린에 statusBarsPadding 적용

81e370e

feat: 필터 적용 여부 계산 로직 추가

0934e05

refactor: 스트링 하드코딩

923ee97

feat: 필터 검색 결과가 없는 경우의 null 화면 적용

f4a7e4c

refactor: 리스트 전환 아이콘 간격 조정

bc552bc

yeonjeen requested a review from a team July 27, 2025 14:42

yeonjeen self-assigned this Jul 27, 2025

yeonjeen added 🍯 [FEAT] 새로운 기능을 개발합니다. 👛 황후 연진 labels Jul 27, 2025

github-actions bot requested review from junseo511, m6z1 and s9hn July 27, 2025 14:42

s9hn approved these changes Jul 27, 2025

View reviewed changes

yeonjeen merged commit 6301fbc into feat/704 Jul 28, 2025
2 checks passed

m6z1 deleted the feat/727 branch August 11, 2025 15:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: 서재UI/UX 개편 (12) - 3차 QA 반영#729

feat: 서재UI/UX 개편 (12) - 3차 QA 반영#729
yeonjeen merged 14 commits intofeat/704from
feat/727

yeonjeen commented Jul 27, 2025

Uh oh!

coderabbitai bot commented Jul 27, 2025

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

s9hn left a comment

Uh oh!

s9hn Jul 27, 2025

Uh oh!

yeonjeen Jul 27, 2025

Uh oh!

s9hn Jul 28, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

yeonjeen commented Jul 27, 2025

📌𝘐𝘴𝘴𝘶𝘦𝘴

📎𝘞𝘰𝘳𝘬 𝘋𝘦𝘴𝘤𝘳𝘪𝘱𝘵𝘪𝘰𝘯

📷𝘚𝘤𝘳𝘦𝘦𝘯𝘴𝘩𝘰𝘵

💬𝘛𝘰 𝘙𝘦𝘷𝘪𝘦𝘸𝘦𝘳𝘴

Uh oh!

coderabbitai bot commented Jul 27, 2025

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

s9hn left a comment

Choose a reason for hiding this comment

Uh oh!

s9hn Jul 27, 2025

Choose a reason for hiding this comment

Uh oh!

yeonjeen Jul 27, 2025

Choose a reason for hiding this comment

Uh oh!

s9hn Jul 28, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

CodeRabbit Configuration File (`.coderabbit.yaml`)