Skip to content

feat: targetSdk35 로 수정 #739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
m6z1 merged 3 commits into from
Aug 9, 2025
Merged

feat: targetSdk35 로 수정 #739

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c6543cb
feat: targetSdk 35 명시
m6z1 Aug 9, 2025
57ad96b
Merge branch 'develop' of https://github.com/Team-WSS/WSS-Android int…
m6z1 Aug 9, 2025
107baf7
feat: resource 모듈 compileSdk 35로 업데이트
m6z1 Aug 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions app/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@ android {
versionName = libs.versions.versionName.get()
testInstrumentationRunner = "androidx.test.runner.AndroidJUnitRunner"

targetSdk = 35

buildConfigs(rootDir) {
string(name = "S3_BASE_URL", key = "s3.url")
string(name = "KAKAO_APP_KEY", key = "kakao.app.key")
Expand Down
2 changes: 1 addition & 1 deletion build-logic/src/main/kotlin/websoso.android.kotlin.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ plugins {
}

androidExtension.apply {
compileSdk = 34
compileSdk = 35
Copy link

@coderabbitai coderabbitai bot Aug 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

🧩 Analysis chain

compileSdk 35 적용 LGTM — 툴체인/CI 호환성만 확인 부탁

설정 자체는 문제 없습니다. Kotlin/JVM 17 설정과도 일치합니다. CI 환경에 Android SDK 35(Platform/Build-Tools)가 설치되어 있는지, 그리고 사용 중인 AGP 버전이 SDK 35를 공식 지원하는지 확인해 주세요.

아래 스크립트로 레포 전체에서 compileSdk/targetSdk 사용 현황과 AGP/플러그인 버전을 점검할 수 있습니다.

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "== compileSdk / targetSdk 선언 위치 점검 =="
rg -n --hidden -S $'compileSdk\\s*=\\s*' || true
rg -n --hidden -S $'targetSdk\\s*=\\s*' || true

echo
echo "== Android Gradle Plugin/플러그인 버전 단서 검색 =="
rg -n --hidden -S 'com.android.tools.build:gradle' || true
rg -n --hidden -S 'id\\(\"com.android.application\"\\)|id\\(\"com.android.library\"\\)' -A 2 || true
fd -H libs.versions.toml | xargs -I{} sh -c 'echo "---- {} ----"; cat "{}"'

echo
echo "== Gradle 플러그인 버전 카탈로그 내 android/AGP 관련 키워드 점검 =="
rg -n --hidden -S 'agp|androidGradlePlugin|com.android' --glob 'libs.versions.toml' || true

Length of output: 9566

컴파일 SDK 35 통일 및 CI 환경 확인 요청

  • core/resource 모듈(core/resource/build.gradle.kts:7)이 여전히 compileSdk = 34로 설정되어 있습니다. 35로 업데이트해주세요.
  • app 모듈에서는 이미 targetSdk = 35로 설정되어 있습니다.
  • gradle/libs.versions.toml에서 Android Gradle Plugin 버전은 8.1.3으로 확인되며, AGP 8.1.3은 compileSdk 35를 공식 지원합니다.
  • CI 환경에 Android SDK 35(Platform/Build-Tools)가 설치되어 있는지 검증 부탁드립니다.
🤖 Prompt for AI Agents 
In build-logic/src/main/kotlin/websoso.android.kotlin.gradle.kts at line 11,
update the compileSdk version from 34 to 35 to unify the compile SDK version
across modules. Also, check the core/resource module's build.gradle.kts file at
line 7 and update its compileSdk to 35. Verify that the CI environment has
Android SDK 35 platform and build-tools installed to support this change.


defaultConfig {
minSdk = 30
Expand Down
2 changes: 1 addition & 1 deletion core/resource/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ plugins {

android {
namespace = "com.into.websoso.core.resource"
compileSdk = 34
compileSdk = 35

defaultConfig {
minSdk = 30
Expand Down