Merged
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
Walkthrough스포일러 포함 게시물에서 이미지 미리보기와 개수 배지를 비노출하도록 이미지 렌더링 블록을 비스포일러(else) 분기로 이동시키고, 외부에 있던 이미지 블록과 여분의 spacer를 제거하며 spacer 위치/간격을 조정했습니다. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
s9hn
reviewed
Mar 13, 2026
Member
s9hn
left a comment
s9hn
left a comment
There was a problem hiding this comment.
@Sadturtleman 코멘트 하나만 확인 부탁드립니다 !
| @@ -228,40 +261,6 @@ private fun FeedItem( | |||
|
|
|||
| Spacer(modifier = Modifier.height(height = 20.dp)) | |||
Member
There was a problem hiding this comment.
c: 이 Spacer도 같이 옮겨져야할 것 같아요! 혹시 모르니 피그마 시안으로 간격 검토 한번 부탁드립니다!
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In
`@feature/feed/src/main/java/com/into/websoso/feature/feed/component/FeedSection.kt`:
- Around line 218-250: The image preview is currently rendered inside the wrong
branch so spoilers still show images; update the condition around the image
block (the Box/NetworkImage + count badge and Spacer tied to feed.imageUrls) to
render only when the post is not a spoiler—i.e., guard with !feed.isSpoiler &&
feed.imageUrls.isNotEmpty() (or move the existing image block out of the
feed.isSpoiler branch and into the non-spoiler branch) so non-spoiler posts keep
their preview and spoiler posts hide images; ensure references to
feed.imageUrls.firstOrNull(), feed.imageCount and the count badge remain
unchanged.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: b543f298-28cd-425a-b2cd-4ff0ca1edd67
📒 Files selected for processing (1)
feature/feed/src/main/java/com/into/websoso/feature/feed/component/FeedSection.kt
Comment on lines
+218
to
+250
| if (feed.imageUrls.isNotEmpty()) { | ||
| Box { | ||
| NetworkImage( | ||
| imageUrl = feed.imageUrls.firstOrNull().orEmpty(), | ||
| modifier = Modifier | ||
| .fillMaxWidth() | ||
| .aspectRatio(ratio = 334f / 237f) | ||
| .clip(RoundedCornerShape(size = 14.dp)), | ||
| contentScale = ContentScale.Crop, | ||
| ) | ||
|
|
||
| Box( | ||
| contentAlignment = Alignment.Center, | ||
| modifier = Modifier | ||
| .align(alignment = Alignment.BottomEnd) | ||
| .padding(end = 12.dp, bottom = 10.dp) | ||
| .size(size = 20.dp) | ||
| .background( | ||
| color = GrayToast, | ||
| shape = CircleShape, | ||
| ), | ||
| ) { | ||
| Text( | ||
| text = feed.imageCount.toString(), | ||
| style = WebsosoTheme.typography.body5, | ||
| color = White, | ||
| textAlign = TextAlign.Center, | ||
| ) | ||
| } | ||
| } | ||
|
|
||
| Spacer(modifier = Modifier.height(height = 10.dp)) | ||
| } |
There was a problem hiding this comment.
스포일러 이미지 노출 조건이 요구사항과 반대로 적용되었습니다
Line 218 기준으로 이미지 블록이 feed.isSpoiler 분기 안에 있어, 스포일러 게시글에서 이미지가 노출됩니다. PR 목표(#830)는 반대로 “스포일러일 때 이미지 숨김”입니다. 또한 현재 구조는 비스포일러 게시글의 이미지 프리뷰를 잃는 회귀를 유발합니다.
수정 제안 diff
- if (feed.isSpoiler) {
+ if (feed.isSpoiler) {
Text(
text = "스포일러가 포함된 글 보기",
style = WebsosoTheme.typography.body2,
color = Secondary100,
modifier = Modifier.debouncedClickable { onContentClick(feed.id, feed.isLiked) },
)
- if (feed.imageUrls.isNotEmpty()) {
- Box {
- NetworkImage(
- imageUrl = feed.imageUrls.firstOrNull().orEmpty(),
- modifier = Modifier
- .fillMaxWidth()
- .aspectRatio(ratio = 334f / 237f)
- .clip(RoundedCornerShape(size = 14.dp)),
- contentScale = ContentScale.Crop,
- )
-
- Box(
- contentAlignment = Alignment.Center,
- modifier = Modifier
- .align(alignment = Alignment.BottomEnd)
- .padding(end = 12.dp, bottom = 10.dp)
- .size(size = 20.dp)
- .background(
- color = GrayToast,
- shape = CircleShape,
- ),
- ) {
- Text(
- text = feed.imageCount.toString(),
- style = WebsosoTheme.typography.body5,
- color = White,
- textAlign = TextAlign.Center,
- )
- }
- }
-
- Spacer(modifier = Modifier.height(height = 10.dp))
- }
} else {
Text(
text = feed.content,
style = WebsosoTheme.typography.body2,
color = Black,
maxLines = 5,
overflow = TextOverflow.Ellipsis,
modifier = Modifier.debouncedClickable { onContentClick(feed.id, feed.isLiked) },
)
+ if (feed.isVisible) {
+ Box {
+ NetworkImage(
+ imageUrl = feed.imageUrls.firstOrNull().orEmpty(),
+ modifier = Modifier
+ .fillMaxWidth()
+ .aspectRatio(ratio = 334f / 237f)
+ .clip(RoundedCornerShape(size = 14.dp)),
+ contentScale = ContentScale.Crop,
+ )
+ Box(
+ contentAlignment = Alignment.Center,
+ modifier = Modifier
+ .align(alignment = Alignment.BottomEnd)
+ .padding(end = 12.dp, bottom = 10.dp)
+ .size(size = 20.dp)
+ .background(color = GrayToast, shape = CircleShape),
+ ) {
+ Text(
+ text = feed.imageCount.toString(),
+ style = WebsosoTheme.typography.body5,
+ color = White,
+ textAlign = TextAlign.Center,
+ )
+ }
+ }
+ Spacer(modifier = Modifier.height(height = 10.dp))
+ }
}🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In
`@feature/feed/src/main/java/com/into/websoso/feature/feed/component/FeedSection.kt`
around lines 218 - 250, The image preview is currently rendered inside the wrong
branch so spoilers still show images; update the condition around the image
block (the Box/NetworkImage + count badge and Spacer tied to feed.imageUrls) to
render only when the post is not a spoiler—i.e., guard with !feed.isSpoiler &&
feed.imageUrls.isNotEmpty() (or move the existing image block out of the
feed.isSpoiler branch and into the non-spoiler branch) so non-spoiler posts keep
their preview and spoiler posts hide images; ensure references to
feed.imageUrls.firstOrNull(), feed.imageCount and the count badge remain
unchanged.
m6z1
approved these changes
Mar 13, 2026
Member
m6z1
left a comment
m6z1
left a comment
There was a problem hiding this comment.
스포일러 글일 때 글과 이미지가 함께 안 보여야 합니다 !
지금 거는 빌드해보니까 글은 뜨는 상태인데 확인 부탁드려요
There was a problem hiding this comment.
🧹 Nitpick comments (1)
feature/feed/src/main/java/com/into/websoso/feature/feed/component/FeedSection.kt (1)
229-229: 조건식은feed.isVisible로 단일화하면 유지보수가 더 쉬워집니다.현재 구조도 동작은 맞지만,
FeedUiModel의 계산 프로퍼티와 조건을 맞춰두면 향후 조건 변경 시 드리프트를 줄일 수 있습니다.제안 diff
- if (feed.imageUrls.isNotEmpty()) { + if (feed.isVisible) { Box { NetworkImage( imageUrl = feed.imageUrls.firstOrNull().orEmpty(),🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@feature/feed/src/main/java/com/into/websoso/feature/feed/component/FeedSection.kt` at line 229, Unify the visibility check by replacing the current conditional that uses feed.imageUrls.isNotEmpty() with the FeedUiModel's computed property feed.isVisible so that visibility logic is centralized; update the conditional in the FeedSection code (where feed.imageUrls is currently checked) to use feed.isVisible, and ensure any related branches that previously relied on imageUrls emptiness still behave correctly under the unified feed.isVisible rule.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In
`@feature/feed/src/main/java/com/into/websoso/feature/feed/component/FeedSection.kt`:
- Line 229: Unify the visibility check by replacing the current conditional that
uses feed.imageUrls.isNotEmpty() with the FeedUiModel's computed property
feed.isVisible so that visibility logic is centralized; update the conditional
in the FeedSection code (where feed.imageUrls is currently checked) to use
feed.isVisible, and ensure any related branches that previously relied on
imageUrls emptiness still behave correctly under the unified feed.isVisible
rule.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 3695f0d0-f4b6-4605-b7e5-edca8b4705bf
📒 Files selected for processing (1)
feature/feed/src/main/java/com/into/websoso/feature/feed/component/FeedSection.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌𝘐𝘴𝘴𝘶𝘦𝘴
📎𝘞𝘰𝘳𝘬 𝘋𝘦𝘴𝘤𝘳𝘪𝘱𝘵𝘪𝘰𝘯
📷𝘚𝘤𝘳𝘦𝘦𝘯𝘴𝘩𝘰𝘵
💬𝘛𝘰 𝘙𝘦𝘷𝘪𝘦𝘸𝘦𝘳𝘴
스포일러 시 이미지 보이지 않게 하기 위해 이미지 분기를 스포일러 분기에 포함시켰습니다.
Summary by CodeRabbit
릴리스 노트