Conversation
- 검색바 도입 - 기능 간 간격 조정 - 기능명 강조를 위한 문구 수정
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
Walkthrough홈 화면에 일반 검색 블록이 추가되고 레이아웃 마진이 조정되었으며, 검색 버튼 클릭 시 "general_search" 이벤트를 추적하고 NormalExploreActivity를 시작하도록 클릭 핸들러가 추가되었습니다. 일부 UI 문자열에 장식/이모지 변경이 적용되었습니다. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant HomeFragment
participant Tracker
participant System as Launcher
User->>HomeFragment: clHomeNormalSearch 클릭
HomeFragment->>Tracker: trackEvent("general_search")
Tracker-->>HomeFragment: ACK
HomeFragment->>System: startActivity(NormalExploreActivity)
System-->>HomeFragment: ActivityStarted
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip CodeRabbit can suggest fixes for GitHub Check annotations.Configure the |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@app/src/main/java/com/into/websoso/ui/main/home/HomeFragment.kt`:
- Around line 115-120: The click handler onNormalSearchButtonClick currently
uses startActivity(intent), which bypasses the ActivityResult flow and prevents
the startActivityLauncher branch that handles NormalExploreBack.RESULT_OK from
running; update the handler bound to binding.clHomeNormalSearch to launch the
NormalExploreActivity via the existing startActivityLauncher (or the
ActivityResultLauncher used elsewhere) instead of startActivity so that
returning with NormalExploreBack.RESULT_OK triggers the feed/novel refresh logic
handled by startActivityLauncher.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: bf6820d8-ae4a-4601-ab3e-e355f8cd7ae1
📒 Files selected for processing (3)
app/src/main/java/com/into/websoso/ui/main/home/HomeFragment.ktapp/src/main/res/layout/fragment_home.xmlcore/resource/src/main/res/values/strings.xml
Comment on lines
+115
to
+120
| private fun onNormalSearchButtonClick() { | ||
| binding.clHomeNormalSearch.setOnClickListener { | ||
| tracker.trackEvent("general_search") | ||
| val intent = NormalExploreActivity.getIntent(requireContext()) | ||
| startActivity(intent) | ||
| } |
There was a problem hiding this comment.
일반 검색 진입이 ActivityResult 경로를 우회해 홈 갱신이 누락됩니다.
여기서는 startActivity(intent)를 사용해서, NormalExploreBack.RESULT_OK를 처리하는 startActivityLauncher 분기(피드/소설 갱신)가 호출되지 않습니다. 일반 검색에서 돌아온 뒤 홈 데이터가 stale 상태로 남을 수 있습니다.
수정 예시
private fun onNormalSearchButtonClick() {
binding.clHomeNormalSearch.setOnClickListener {
tracker.trackEvent("general_search")
- val intent = NormalExploreActivity.getIntent(requireContext())
- startActivity(intent)
+ startActivityLauncher.launch(
+ NormalExploreActivity.getIntent(requireContext()),
+ )
}
}📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| private fun onNormalSearchButtonClick() { | |
| binding.clHomeNormalSearch.setOnClickListener { | |
| tracker.trackEvent("general_search") | |
| val intent = NormalExploreActivity.getIntent(requireContext()) | |
| startActivity(intent) | |
| } | |
| private fun onNormalSearchButtonClick() { | |
| binding.clHomeNormalSearch.setOnClickListener { | |
| tracker.trackEvent("general_search") | |
| startActivityLauncher.launch( | |
| NormalExploreActivity.getIntent(requireContext()), | |
| ) | |
| } | |
| } |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@app/src/main/java/com/into/websoso/ui/main/home/HomeFragment.kt` around lines
115 - 120, The click handler onNormalSearchButtonClick currently uses
startActivity(intent), which bypasses the ActivityResult flow and prevents the
startActivityLauncher branch that handles NormalExploreBack.RESULT_OK from
running; update the handler bound to binding.clHomeNormalSearch to launch the
NormalExploreActivity via the existing startActivityLauncher (or the
ActivityResultLauncher used elsewhere) instead of startActivity so that
returning with NormalExploreBack.RESULT_OK triggers the feed/novel refresh logic
handled by startActivityLauncher.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌𝘐𝘴𝘴𝘶𝘦𝘴
📎𝘞𝘰𝘳𝘬 𝘋𝘦𝘴𝘤𝘳𝘪𝘱𝘵𝘪𝘰𝘯
📷𝘚𝘤𝘳𝘦𝘦𝘯𝘴𝘩𝘰𝘵
💬𝘛𝘰 𝘙𝘦𝘷𝘪𝘦𝘸𝘦𝘳𝘴
Summary by CodeRabbit
릴리스 노트
새 기능
스타일