Add scikit-learn-contrib/stability-selection and improve randomized_l1 transformers#308
Add scikit-learn-contrib/stability-selection and improve randomized_l1 transformers#308teabolt wants to merge 7 commits into
Conversation
…mer (if scikit-learn-contrib/stability-selection available)
…earn) and stability_selection (scikit-learn-contrib)
… sklearn/transform.py
…andomizedLasso of scikit-learn < 0.19 (fix failed CI build)
Codecov Report
@@ Coverage Diff @@
## master #308 +/- ##
==========================================
- Coverage 97.09% 97.07% -0.03%
==========================================
Files 44 44
Lines 2856 2868 +12
Branches 542 543 +1
==========================================
+ Hits 2773 2784 +11
- Misses 45 46 +1
Partials 38 38
|
|
Re: two test parametrizations for RandomizedLasso, one for scikit-learn < 0.19 and another for scikit-learn >= 0.19. It might be possible to reduce these to just one test by passing certain parameters to the RandomizedLasso so that the same features are selected in both scikit-learn versions. See also history of randomized_l1 https://github.com/scikit-learn/scikit-learn/commits/0.20.X/sklearn/linear_model/randomized_l1.py for what might be causing the difference in selected features. |
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #308 +/- ##
==========================================
- Coverage 97.09% 97.07% -0.03%
==========================================
Files 44 44
Lines 2856 2868 +12
Branches 542 543 +1
==========================================
+ Hits 2773 2784 +11
- Misses 45 46 +1
Partials 38 38
🚀 New features to boost your workflow:
|
Closes #305.
stability_selection.StabilitySelection(https://github.com/scikit-learn-contrib/stability-selection) as an argument totransform_feature_names.Coverage should increase once scikit-learn 0.21 and scikit-learn-contrib/stability-selection are tested against (could modify the tox config for this?).
If more use cases come up for functions like
register_notnoneandinstantiate_notnone, they could be moved tobase_utils.pyor similar.