Skip to content

Fixed depreciated inspect function#396

Open
icfly2 wants to merge 1 commit into
TeamHG-Memex:masterfrom
icfly2:patch-1
Open

Fixed depreciated inspect function#396
icfly2 wants to merge 1 commit into
TeamHG-Memex:masterfrom
icfly2:patch-1

Conversation

@icfly2

@icfly2 icfly2 commented Dec 9, 2020

Copy link
Copy Markdown
Contributor

getfullargspec is a drop in replacement for getargspec, see docs for details

`getfullargspec` is a drop in replacement for `getargspec`, see https://docs.python.org/3/library/inspect.html#inspect.getargspec for details
@codecov-io

Copy link
Copy Markdown

Codecov Report

Merging #396 (fca6d57) into master (017c738) will decrease coverage by 17.25%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           master     #396       +/-   ##
===========================================
- Coverage   97.32%   80.07%   -17.26%     
===========================================
  Files          49       49               
  Lines        3142     3142               
  Branches      585      585               
===========================================
- Hits         3058     2516      -542     
- Misses         44      581      +537     
- Partials       40       45        +5     
Impacted Files Coverage Δ
eli5/base_utils.py 90.00% <100.00%> (-10.00%) ⬇️
eli5/keras/gradcam.py 0.00% <0.00%> (-100.00%) ⬇️
eli5/xgboost.py 4.26% <0.00%> (-95.13%) ⬇️
eli5/formatters/image.py 5.47% <0.00%> (-94.53%) ⬇️
eli5/keras/explain_prediction.py 4.81% <0.00%> (-91.57%) ⬇️
eli5/lightgbm.py 4.27% <0.00%> (-90.60%) ⬇️
eli5/catboost.py 11.53% <0.00%> (-88.47%) ⬇️
eli5/_decision_path.py 35.48% <0.00%> (-64.52%) ⬇️
eli5/keras/__init__.py 50.00% <0.00%> (-50.00%) ⬇️
eli5/ipython.py 85.71% <0.00%> (-14.29%) ⬇️
... and 12 more

@icfly2

icfly2 commented Dec 10, 2020

Copy link
Copy Markdown
Contributor Author

Surely this is due to a change in tests not related to this PR

@lopuhin

lopuhin commented Feb 10, 2021

Copy link
Copy Markdown
Contributor

Thanks you! This were merged in eli5-org/eli5#2 and released to PyPI with v0.11

@codecov-commenter

Copy link
Copy Markdown

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants