This repository was archived by the owner on May 13, 2024. It is now read-only.
Refactoring #5
Closed
Refactoring #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Closing due to inactivity and lack of feasibility due to the divergence between his fork and my repository. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've seen that you have improved many of my beginner's Python code and refactored most of the stuff. I see however that some stuff is not finished/moved from the original version, bugs from the original version are still there and it doesn't use asyncio as modern Telethon versions do.
I made TLImporter just for using it once, but I welcome all kinds of improvements to it for future users, so, if you want, we can contribute and test stuff together and I can merge your changes into the main repository.
Do you have any roadmap to finish the group importing feature? Any plans to get your changes merged or do you want them to stay apart? Do you think that the code works well or it has some quirks after the refactor? Works good with PyInstaller I suppose, right?
Count on me for everything you want to ask/need. Take this PR as an opportunity to introduce myself :)