Skip to content

fix(android): fix vsync accumulation bug #4426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
etkmao merged 1 commit into from
Oct 10, 2025
Merged

fix(android): fix vsync accumulation bug #4426

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions renderer/native/android/src/main/java/com/tencent/renderer/utils/ChoreographerUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,24 +18,24 @@

import android.view.Choreographer;
import androidx.annotation.MainThread;
import java.util.ArrayList;
import java.util.HashMap;
import java.util.HashSet;
import java.util.Map.Entry;

public class ChoreographerUtils {

public static final String DO_FRAME = "frameUpdate";
private static boolean sEnablePostFrame = false;
private static HashMap<Integer, ArrayList<Integer>> sListeners = null;
private static HashMap<Integer, HashSet<Integer>> sListeners = null;

private static void handleDoFrameCallback() {
for (Entry<Integer, ArrayList<Integer>> entry : sListeners.entrySet()) {
for (Entry<Integer, HashSet<Integer>> entry : sListeners.entrySet()) {
Integer rendererId = entry.getKey();
ArrayList<Integer> rootList = entry.getValue();
if (rootList == null) {
HashSet<Integer> rootSet = entry.getValue();
if (rootSet == null) {
continue;
}
for (Integer rootId : rootList) {
for (Integer rootId : rootSet) {
EventUtils.sendRootEvent(rendererId, rootId, DO_FRAME, null);
}
}
Expand All @@ -62,9 +62,9 @@ public static void registerDoFrameListener(Integer rendererId, Integer rootId) {
if (sListeners == null) {
sListeners = new HashMap<>();
}
ArrayList<Integer> roots = sListeners.get(rendererId);
HashSet<Integer> roots = sListeners.get(rendererId);
if (roots == null) {
roots = new ArrayList<>();
roots = new HashSet<>();
roots.add(rootId);
sListeners.put(rendererId, roots);
} else {
Expand All @@ -87,7 +87,7 @@ public static void unregisterDoFrameListener(Integer rendererId, Integer rootId)
if (sListeners == null) {
return;
}
ArrayList<Integer> roots = sListeners.get(rendererId);
HashSet<Integer> roots = sListeners.get(rendererId);
if (roots != null) {
roots.remove(rootId);
if (roots.isEmpty()) {
Expand Down
Loading